Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”πŸ—¨οΈ Unified Search in individual Talk room #42914

Closed
2 tasks
AndyScherzinger opened this issue Jan 18, 2024 · 2 comments Β· Fixed by #43189 or nextcloud/spreed#11575
Closed
2 tasks

πŸ”πŸ—¨οΈ Unified Search in individual Talk room #42914

AndyScherzinger opened this issue Jan 18, 2024 · 2 comments Β· Fixed by #43189 or nextcloud/spreed#11575
Assignees
Labels
1. to develop Accepted and waiting to be taken care of enhancement πŸ€ 2024-Spring
Milestone

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jan 18, 2024

How to use GitHub

  • Please use the πŸ‘ reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
Currently you can limit searches via unified search to be limited to a talk room or folder

Describe the solution you'd like
Extend the current unified search implementation to allow for limiting a search to a specific Talk room or a folder in Files.

Describe alternatives you've considered
none

Current requirements that need to be discussed:

  • Implementing filter : value in Unified search
  • Filter translation for non-english speakers, e.g. "conversation" -> "raum", etc.
@AndyScherzinger AndyScherzinger added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap πŸ€ 2024-Spring labels Jan 18, 2024
@AndyScherzinger AndyScherzinger added this to the Nextcloud 29 milestone Jan 18, 2024
@AndyScherzinger AndyScherzinger changed the title Implement Search in individual Talk room πŸ”πŸ—¨οΈ Implement Search in individual Talk room Jan 18, 2024
@AndyScherzinger AndyScherzinger changed the title πŸ”πŸ—¨οΈ Implement Search in individual Talk room πŸ”πŸ—¨οΈ Unified Search in individual Talk room Jan 18, 2024
@AndyScherzinger AndyScherzinger added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 18, 2024
@sorbaugh sorbaugh assigned Altahrim and Fenn-CS and unassigned sorbaugh Jan 19, 2024
@sorbaugh
Copy link
Contributor

@marcoambrosini do we need some mockups here?

Also, here is an example of the filter : value syntax as it was implemented on deck -> nextcloud/deck#2934

@marcoambrosini marcoambrosini self-assigned this Jan 22, 2024
@marcoambrosini
Copy link
Member

marcoambrosini commented Jan 22, 2024

I think that a quick and easy solution for this would be:

  • Add a "Conversation" filter in "Apps and settings"
  • Clicking on this filter brings up the same smart picker conversation search component that allows to choose a conversation. (This can be done for folders, deck boards and so forth)
  • Rename the current "Conversations" filter to "Talk" for better clarity
  • Rename the current apps and settings into something else more inclusive of all the possibilities. "Places" was suggested by @jancborchardt in the past.
  • Add search box for the Apps and settings menu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment