Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP API for optional indices #42169

Closed
ChristophWurst opened this issue Dec 12, 2023 · 4 comments
Closed

OCP API for optional indices #42169

ChristophWurst opened this issue Dec 12, 2023 · 4 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement performance 🚀

Comments

@ChristophWurst
Copy link
Member

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.

As a Nextcloud app developer I might identify missing database indices like nextcloud/mail#9160. Applying the indices in a migration means they are always added and tables with data block the migration for x seconds/minutes/hours depending on table size.

Describe the solution you'd like

Allow apps to hook into the optional indices API of server so that they can also advertise a missing, but optional index that admins can apply later on.

Describe alternatives you've considered

N/a

Additional context

This was started in #25471 but closed due to inactivity.

@ChristophWurst ChristophWurst added enhancement 1. to develop Accepted and waiting to be taken care of performance 🚀 labels Dec 12, 2023
@ChristophWurst ChristophWurst changed the title App API for optional indices OCP API for optional indices Dec 12, 2023
@ChristophWurst
Copy link
Member Author

When adding this API we might also consider adding support for replacing indices.

I noticed that occasionally we have indices that are not ideal. A migration could drop the old index (relatively cheap) and add the new one through this API (relatively expensive) but that means the instance is slow in the time between the two events. If the API took care of dropping, the time of slowness would be minimal.

@come-nc
Copy link
Contributor

come-nc commented Dec 12, 2023

@come-nc
Copy link
Contributor

come-nc commented Dec 12, 2023

@ChristophWurst
Copy link
Member Author

Right! I searched closed PRs but could only find the status checks API. Awesome 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement performance 🚀
Projects
None yet
Development

No branches or pull requests

2 participants