Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not create folders with a unique name when not having update permissions #41260

Closed
Tracked by #3888
nickvergessen opened this issue Nov 3, 2023 · 6 comments · Fixed by #42993
Closed
Tracked by #3888

Can not create folders with a unique name when not having update permissions #41260

nickvergessen opened this issue Nov 3, 2023 · 6 comments · Fixed by #42993

Comments

@nickvergessen
Copy link
Member

nickvergessen commented Nov 3, 2023

Steps

  1. As UserA create a folder FolderA
  2. As UserA share FolderA with UserB with read+create permissions
  3. As UserB try to create a FolderB inside FolderA
  4. The folder New folder gets created and due to lack of update permissions you can not rename it:

grafik

@nickvergessen nickvergessen changed the title Can not create folders with a unique name when not having edit permissions Can not create folders with a unique name when not having update permissions Nov 3, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Nov 3, 2023

Suggestion:

  • If current folder does not have Update permission
  • OR if files_accesscontrol is enabled

we open a modal to request the name instead of creating before and renaming

@szaimen szaimen added the bug label Nov 29, 2023
@sorbaugh
Copy link
Contributor

While this in't good from a UX perspective, due to the lack of Update permissions, Nextcloud is technically behaving "correctly" here, I suppose? Did the behavior change with NC 28?

@nickvergessen
Copy link
Member Author

Nextcloud is technically behaving "correctly" here, I suppose?

The backend yes. The frontend needs to adapt and should only send the MKDIR/PUT request once the user had the chance to give the folder/file name

Did the behavior change with NC 28?

Yes, its a regression from Files2vue migration, immediatelly creating the folder/file as "New folder" instead of taking user input.

@szaimen
Copy link
Contributor

szaimen commented Jan 3, 2024

cc @nextcloud/files

@come-nc
Copy link
Contributor

come-nc commented Jan 4, 2024

Even without the permission situation, using create+rename instead of just create is annoying, for instance it looks weird in activity:
Screenshot_20240104_142413

And users could have flows running at folder creation also.

@szaimen

This comment was marked as spam.

@AndyScherzinger AndyScherzinger moved this to 📄 To do (~10 entries) in 📁 Files team Jan 18, 2024
@susnux susnux assigned susnux and unassigned nfebe Jan 21, 2024
@susnux susnux moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📁 Files team Jan 21, 2024
@susnux susnux added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jan 21, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment