Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔎 AS - Move search into a modal dialog and add Layout + Vue Components for filtering #40238

Closed
Tracked by #39162
sorbaugh opened this issue Sep 4, 2023 · 1 comment
Closed
Tracked by #39162

🔎 AS - Move search into a modal dialog and add Layout + Vue Components for filtering #40238

sorbaugh opened this issue Sep 4, 2023 · 1 comment
Assignees
@nfebe
Labels
enhancement feature: files feature: search ❄️ 2023-Winter
Milestone
Nextcloud 28

Comments

@sorbaugh
Copy link
Contributor

sorbaugh commented Sep 4, 2023 •
edited
Loading

Improve UX for Advanced Search functionality.

Mockup:
Bildschirmfoto 2023-09-04 um 13 50 04

Link to Nc Vue Documentation
@sorbaugh sorbaugh mentioned this issue Sep 4, 2023
Closed
7 tasks
@sorbaugh sorbaugh moved this to 📄 To do (~10 entries) in 📁 Files team Sep 4, 2023
@sorbaugh sorbaugh added this to the Nextcloud 28 milestone Sep 4, 2023
@sorbaugh sorbaugh changed the title Move search into a modal dialog and add Layout + Vue Components for filtering. Nc Vue documentation Move search into a modal dialog and add Layout + Vue Components for filtering Sep 4, 2023
@AndyScherzinger AndyScherzinger changed the title Move search into a modal dialog and add Layout + Vue Components for filtering 🔎 Move search into a modal dialog and add Layout + Vue Components for filtering Sep 5, 2023
@sorbaugh sorbaugh changed the title 🔎 Move search into a modal dialog and add Layout + Vue Components for filtering 🔎 AS - Move search into a modal dialog and add Layout + Vue Components for filtering Sep 19, 2023
@sorbaugh
Copy link
Contributor Author

sorbaugh commented Oct 17, 2023 •
edited
Loading

Feedback from Design Call

  • Add heading: "Global search"
  • Close button missing for the modal
  • "Global search" --> "Search term..."
  • Chips (Files, Talk, etc),
    • style it like NcUserBubble component
    • Border radius pill
    • Background: --color-primary-light or grey
    • Smaller close icon
  • Result styling
    • should be like NcListItem component
    • remove shadow
    • Show "Search in [appname]" only for the apps that have an in-app search. Files doesn't have an in-app search yet, so don't show "Search in Files"
  • "Places"
    • Wording: "Apps and settings"
    • Style should be NcButton
    • Clicking on button opens an NcActionMenu with a list of the available apps, similar to app list in mobile view header bar
  • "People"
    • Needs label "People"
    • Use component NcSelect with userSelect prop
  • "Date and time"
    • NcButton component
    • Button name "Modified"
    • On click, open action menu with predefined date options and a date range picker
    • Use native date picker for date range

@nfebe nfebe moved this from 📄 To do (~10 entries) to ☑️ Done in 📁 Files team Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfebe nfebe

Labels
enhancement feature: files feature: search ❄️ 2023-Winter
Projects
📁 Files team
Archived in project
Milestone
Nextcloud 28
Development

No branches or pull requests
3 participants
@AndyScherzinger @nfebe @sorbaugh