Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: CalDavBackend->getChangesForCalendar() reports move operation events (added, deleted) on wrong calendars #40051

Closed
4 of 8 tasks
ksainc opened this issue Aug 25, 2023 · 3 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 26-feedback bug feature: caldav Related to CalDAV internals

Comments

@ksainc
Copy link

ksainc commented Aug 25, 2023

⚠️ This issue respects the following points: ⚠️

Bug description

CalDavBackend->getChangesForCalendar() reports move operation events (added, deleted) on wrong calendars

Moved calendar object from calendar 26 (Combined) to 24 (Personal). Then ran CalDavBackend->getChangesForCalendar() on both.

Results:

Calendar 24 (Personal) shows delete event but should show added

$this->LocalStore->getChangesForCalendar(24, 132, null, null)
array(4)
    syncToken: 134  
    added: array(0)
    modified: array(0)
    deleted: array(1)
        0: "9ED4BC5B-EE08-4E02-8E49-B341CF5C7E64.ics"

Calendar 26 (Combined) shows added event but should show deleted

$this->LocalStore->getChangesForCalendar(26, 32, null, null)
array(4) 
    syncToken: 33  
    added: array(1)  
        0: "9ED4BC5B-EE08-4E02-8E49-B341CF5C7E64.ics"  
    modified: array(0)  
    deleted: array(0)  

Steps to reproduce

  1. Move event between two calendars
  2. Execute CalDavBackend->getChangesForCalendar() on each calendar

Expected behavior

Report move operation events (added, deleted) on proper calendar

Installation method

None

Nextcloud Server version

26

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Nginx

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@ksainc ksainc added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Aug 25, 2023
@joshtrichards joshtrichards added the feature: caldav Related to CalDAV internals label Aug 26, 2023
@kesselb
Copy link
Contributor

kesselb commented Aug 27, 2023

cc @ChristophWurst @miaulalala

@miaulalala
Copy link
Contributor

Which version of 26 are you using? This might have been fixed in 26.0.2 already by #37812

@ksainc
Copy link
Author

ksainc commented Aug 28, 2023

Good Morning @miaulalala,

Confirmed. Its been fixed.

Thank you.

@ksainc ksainc closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 26-feedback bug feature: caldav Related to CalDAV internals
Projects
None yet
Development

No branches or pull requests

5 participants