Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable caldav push notifications by default #39862

Closed
ChristophWurst opened this issue Aug 14, 2023 · 6 comments · Fixed by #40103
Closed

Enable caldav push notifications by default #39862

ChristophWurst opened this issue Aug 14, 2023 · 6 comments · Fixed by #40103
Assignees
Milestone

Comments

@ChristophWurst
Copy link
Member

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.

As a user of Nextcloud who doesn't use connected clients I want to see a web notification for calendar events.

Describe the solution you'd like

Revert #16970

Describe alternatives you've considered

#39158

Additional context

Needs admin upgrade docs because it will have a big influence on existing setups.

@ChristophWurst ChristophWurst added enhancement 1. to develop Accepted and waiting to be taken care of feature: dav feature: caldav Related to CalDAV internals labels Aug 14, 2023
@ChristophWurst
Copy link
Member Author

In a way this is "breaking" because systems will behave different after this has been deployed. Do we want this change to be included only in 28 or 27.1 as well @AndyScherzinger @jancborchardt?

@jancborchardt
Copy link
Member

I’m fine with either, but I would say 27.1 to get it done?

@AndyScherzinger
Copy link
Member

27.1 would also be fine with me 👍

@AndyScherzinger AndyScherzinger added this to the Nextcloud 27.1.0 milestone Aug 14, 2023
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Sep 6, 2023
@ChristophWurst
Copy link
Member Author

#40103 should be ready for merge now. We are at RC3 of 27.1. I would veto merging this for 27 still because we wouldn't have time to roll back if there are issues with this change.

@ChristophWurst
Copy link
Member Author

@Linkinsoldier
Copy link

I hope this can be disables per settings in the feature. I don't have access to occ and therefore can not disable it ...!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

5 participants