Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write profile properties and backend properties to system address book #37800

Closed
6 of 11 tasks
Tracked by #19575
miaulalala opened this issue Apr 18, 2023 · 5 comments · Fixed by #38073
Closed
6 of 11 tasks
Tracked by #19575

Write profile properties and backend properties to system address book #37800

miaulalala opened this issue Apr 18, 2023 · 5 comments · Fixed by #38073
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Milestone

Comments

@miaulalala
Copy link
Contributor

miaulalala commented Apr 18, 2023

Part of #19575

Part 1: read from user backends
Part 2: write to VCARD

Mapping

@miaulalala miaulalala added enhancement 1. to develop Accepted and waiting to be taken care of labels Apr 18, 2023
@miaulalala miaulalala added this to the Nextcloud 27 milestone Apr 18, 2023
@ChristophWurst ChristophWurst changed the title [Feature] Write profile properties and backend properties to system address book Write profile properties and backend properties to system address book Apr 28, 2023
@ChristophWurst ChristophWurst moved this to 📄 To do (~10 entries) in 💌 📅 👥 Groupware team Apr 28, 2023
@ChristophWurst
Copy link
Member

It looks like role and organization are among the props intentionally not published:

/** List of readable account properties which aren't published to the lookup server */
export const UNPUBLISHED_READABLE_PROPERTIES = Object.freeze([
ACCOUNT_PROPERTY_READABLE_ENUM.BIOGRAPHY,
ACCOUNT_PROPERTY_READABLE_ENUM.HEADLINE,
ACCOUNT_PROPERTY_READABLE_ENUM.ORGANISATION,
ACCOUNT_PROPERTY_READABLE_ENUM.ROLE,
])

@Pytal do you recall the details of this? Do we just not want the four props to ever hit the lookup server? I'd like to use them in the system address book.

This is also related to #19575 (comment). I hope that we can store more local properties in the system addressbook and perhaps filter when we send data to other server?

@ChristophWurst
Copy link
Member

@nickvergessen says these props were not meant for publishing but only the profile.

So two options here

  1. Leave the limitation and accept that the system address book has no role nor organization
  2. Change the allowed scopes of role and organization so they can be stored in the system address book and sent to other federated instances and the lookup server

@Pytal
Copy link
Member

Pytal commented Apr 29, 2023

@Pytal do you recall the details of this? Do we just not want the four props to ever hit the lookup server? I'd like to use them in the system address book.

Can't be super certain but iirc as those 4 new properties were only for profile they were not added to the list of properties to be published alongside the ones in https://github.com/nextcloud/server/blob/d6847a975767bb610018d531d614b50f1da09a98/apps/dav/lib/CardDAV/Converter.php#L59C1-L95

@ChristophWurst
Copy link
Member

So two options here

Option 3: We will address #19575 (comment) because it has wider issues with missing local data in the system address book. So once that is fixed, the private or local role and organization will be mappable. We don't have to make them published/federated.

@ChristophWurst
Copy link
Member

Language -> LANG

We noticed that language is not a profile property. It is a simple user setting shown on the profile settings page.

@jancborchardt do we still want to write a user's configured language as their LANG prop of the system address book contact entry? If so, under what scope? Can we assume everyone is okay with others seeing their language?

Semantically it is tricky to interpret the number of the LANG property because it's not necessarily the user's spoken language but what they configure Nextcloud to be in. I've set my Nextcloud to English while I speak also German.

@JohannesGGE JohannesGGE moved this from 📄 To do (~10 entries) to 🏗️ In progress in 💌 📅 👥 Groupware team May 3, 2023
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels May 4, 2023
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels May 4, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
Development

Successfully merging a pull request may close this issue.

4 participants