Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed footer (banner) blocks view of public shares on smaller screens #36485

Closed
5 of 9 tasks
mcnesium opened this issue Feb 1, 2023 · 3 comments · Fixed by #46784
Closed
5 of 9 tasks

Fixed footer (banner) blocks view of public shares on smaller screens #36485

mcnesium opened this issue Feb 1, 2023 · 3 comments · Fixed by #46784
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 25-feedback bug design Design, UI, UX, etc. feature: sharing

Comments

@mcnesium
Copy link

mcnesium commented Feb 1, 2023

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • Nextcloud Server is running on 64bit capable CPU, PHP and OS.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

Since the latest theme change, the position:fixed-footer on the file drop upload page covers the list of uploaded files:

Here is a screenshot of the page after uploading a file. The page has been scrolled up for a tiny bit so that part of the file name can be seen between the static footer and the end of the browser window:

FullSizeRender.3.MOV

Furthermore, even without uploading, the page looks pretty odd and the difference in white space makes the overall appearance of the page look pretty ugly imho:

Steps to reproduce

  1. go to a "File drop (upload only)" share with a small screen device, e.g. iPhone SE
  2. upload a file
  3. see the file list covered by the page footer with the slogan and stuff

Expected behavior

The footer should be static and always stay below anything else on the page.

Installation method

None

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

Files

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@mcnesium mcnesium added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Feb 1, 2023
@szaimen
Copy link
Contributor

szaimen commented Feb 1, 2023

Hi, which nc version?

@mcnesium
Copy link
Author

mcnesium commented Feb 1, 2023

Sorry, I am seeing this on my instance which is on v25.0.3. The screencast was with whatever demo1.nextcloud.com is on today.

@jmhammond
Copy link

Even on a larger (non-mobile) screen, the footer covers over the uploaded files.

Here my Firefox window isn't full screen, note how it looks like there's nothing under uploaded files
2023-02-06_15-13-26

Here I've made the window larger, and we see that something did in fact upload.
2023-02-06_15-13-39

This is on v25.0.3.

@joshtrichards joshtrichards added design Design, UI, UX, etc. feature: sharing labels Aug 30, 2023
@joshtrichards joshtrichards changed the title [Bug]: Fixed footer on file drop page covers uploaded files on smaller screens Fixed footer (banner) blocks view of public shares on smaller screens Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 25-feedback bug design Design, UI, UX, etc. feature: sharing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants