Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h1 should instead be in the app content, ideally displayed visually #35138

Closed
Tracked by #33741
JuliaKirschenheuter opened this issue Nov 14, 2022 · 0 comments · Fixed by #35147
Closed
Tracked by #33741

h1 should instead be in the app content, ideally displayed visually #35138

JuliaKirschenheuter opened this issue Nov 14, 2022 · 0 comments · Fixed by #35147
Assignees
Labels
3. to review Waiting for reviews

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Nov 14, 2022

<h1> should be never in <span>.

In this issue <h1> should be moved to a content. Could i left <h1>- text in <span>and move actual <h1> behind the image?

image

<header id="header">
<div class="header-left">
<span id="nextcloud">
<div class="logo logo-icon svg"></div>
<h1 class="header-appname">
<?php if (isset($template) && $template->getHeaderTitle() !== '') { ?>
<?php p($template->getHeaderTitle()); ?>
<?php } else { ?>
<?php p($theme->getName()); ?>
<?php } ?>
</h1>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant