Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admins to install beta releases of apps #31611

Closed
max65482 opened this issue Mar 17, 2022 · 10 comments
Closed

Allow admins to install beta releases of apps #31611

max65482 opened this issue Mar 17, 2022 · 10 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement

Comments

@max65482
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Beta versions of apps must be installed via CLI. There is no way to do this via web UI.

Describe the solution you'd like
Admins can install beta versions and release candidates via web UI. It is impossible to downgrade back from the beta version ("the only way is up").

Describe alternatives you've considered
As discussed in #31588, downgrading may lead to inconsistencies and security vulnerabilities.

@max65482 max65482 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Mar 17, 2022
@max65482
Copy link
Contributor Author

Let me kick off the design discussion:

grafik

@jancborchardt @nimishavijay

@jancborchardt
Copy link
Member

Seems good to allow for testing, yes. Howeber to avoid the primary action being something we don't advise, I'd still say let's put it in a 3-dot menu next to the "Disable" button.

There we can also state the info that downgrading might be an issue, thanks for helping testing, please report issues if you find any, etc.

@max65482
Copy link
Contributor Author

Maybe

grafik

@max65482
Copy link
Contributor Author

And shall we show the dots even if there is no beta release available?

@max65482
Copy link
Contributor Author

For clarification: What versions shall be offered? Betas? RCs?
Can I simply match version strings ('-rc', '-beta')?

@max65482
Copy link
Contributor Author

max65482 commented Mar 20, 2022

I'm starting to wonder if this feature is even needed. Admins can select the beta update channel which also influences the app updates. This already allows the installation of beta versions.

grafik

Implementation for apps is here:

$allowPreReleases = $allowUnstable || $this->getChannel() === 'beta' || $this->getChannel() === 'daily' || $this->getChannel() === 'git';
$allowNightly = $allowUnstable || $this->getChannel() === 'daily' || $this->getChannel() === 'git';

@szaimen
Copy link
Contributor

szaimen commented Mar 21, 2022

Hey, thanks for investigating this!
I still think it makes sense to allow to install beta versions from the app store with a dedicated button for each of those because on some instances is the updatenotifications app disabled and thus no way to change the channel using the UI. Also, it is not really expected in my opinion, that this setting also influences which updates get offered in the app store. I get why it was implemented that way (much less engineering effort) but I think it is better from a UX perspective to be able to choose to upgrade to a beta version from the apps page directly.

What do you think @jancborchardt ?

@jancborchardt
Copy link
Member

I'm starting to wonder if this feature is even needed. Admins can select the beta update channel which also influences the app updates. This already allows the installation of beta versions.

I’d agree with you @max65482 – if app betas are already used when you are in the beta channel, then you can have a test setup, and that’s fine – doesn’t overcomplicate things and you have 1 place where you can say "sign me up for possible breakage". Closing then :)

@kescherCode
Copy link

Yeah this issue should probably be re-opened. I want to remain on stable versions of Nextcloud, but use beta versions of some specific apps.

@kescherCode
Copy link

I'm aware that one can switch the channel to achieve this, but that's clunky. Instead, I'd like to switch the channel per-app, ideally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement
Projects
None yet
Development

No branches or pull requests

4 participants