files: fileid param leads to redirect that drops all other params

[azul]

If urls in the files app contain the fileid param they trigger a redirect that drops all other params:

http://nextcloud.local/index.php/apps/files/?dir=/Wiki&fileid=96&openfile=190
-> 303 redirect to
http://nextcloud.local/index.php/apps/files/?dir=/Wiki
-> url changed by javascript to
http://nextcloud.local/index.php/apps/files/?dir=/Wiki&fileid=96

First of all this is odd behaviour and i believe it was introduce to handle links like

/http://nextcloud.local/index.php/f/192

However it's applied to all urls that have a fileid param.

I ran into this because NC 19 introduces the openfile param in the files application that will trigger the viewer for the given file ( #20185 ). However if the url also contains the fileid param opening it in a new tab will trigger a 303 redirect that drops the fileid and all other params.

This is currently not an issue because for the href in the link in the filelist the openfile param is added without thefileid by using this.linkTo(path) ( https://github.com/nextcloud/server/pull/20185/files#diff-dafefd9519924bec4efa9f5af4af8e68R2175 ).
However the link triggers js rather than a page load. So the url stays the same for now. I'm working on adding a function to the viewer app that updates the url / adds it to the history ( nextcloud/viewer#488 ).

The Viewer app is general purpose and can be used in other contexts. Currently the logic for getting the url after loading the viewer is:

• drop fileid param if it's there
• add openfile param
• leave other params as is.
  The removal of the fileid param is somewhat arbitrary. Instead it would be better if adding the openfile param to the current url was enough.

[szaimen]

Is this Issue still valid? If not, please close this issue. Thanks! :)

[ghost]

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.