Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline User Settings Alignment #18420

Closed
gary-kim opened this issue Dec 16, 2019 · 2 comments · Fixed by #18455
Closed

Multiline User Settings Alignment #18420

gary-kim opened this issue Dec 16, 2019 · 2 comments · Fixed by #18455
Assignees
Labels

Comments

@gary-kim
Copy link
Member

gary-kim commented Dec 16, 2019

The changes made in #17239 are great but has made some strange alignment issues.

Steps to reproduce

  1. Go into user settings page as an admin
  2. Click on new user

Expected behaviour

The new fields should line up with the user table.

Actual behaviour

The new fields are not lined up with the user table and is slightly confusing. For instance, the input for display name is right under the header for password.
Screenshot from 2019-12-16 16-33-39

Also, when editing a user, the alignment of quota is slighty strange as it is center aligned while everything else is left aligned.

Screenshot from 2019-12-16 16-37-04

@gary-kim gary-kim added bug design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of labels Dec 16, 2019
@gary-kim gary-kim added this to the Nextcloud 18 milestone Dec 16, 2019
@jospoortvliet
Copy link
Member

@GretaD 🚀

@GretaD
Copy link
Contributor

GretaD commented Dec 17, 2019

Thank you @gary-kim. I will prepare a patch and push it this week.

@GretaD GretaD mentioned this issue Dec 17, 2019
3 tasks
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants