Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File picker dialog shows empty create action box #15966

Closed
juliusknorr opened this issue Jun 15, 2019 · 4 comments
Closed

File picker dialog shows empty create action box #15966

juliusknorr opened this issue Jun 15, 2019 · 4 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug design Design, UI, UX, etc. feature: filepicker good first issue Small tasks with clear documentation about how and in which place you need to fix things in. needs info papercut Annoying recurring issue with possibly simple fix.

Comments

@juliusknorr
Copy link
Member

https://user-images.githubusercontent.com/925062/59440105-b2a2dd80-8df6-11e9-9b45-4a6157db791a.png

When the actions list is empty, we should not show it at all. This seems to be files app related, as it works fine in the avatar picker of the personal settings.
@juliusknorr juliusknorr added bug 1. to develop Accepted and waiting to be taken care of labels Jun 15, 2019
@juliusknorr juliusknorr mentioned this issue Jun 15, 2019
Closed
@szaimen
Copy link
Contributor

szaimen commented May 26, 2021

@juliushaertl could you please advice where this would need to be fixed in the code? Maybe it is simple enough so that I can fix it...

@szaimen szaimen added the design Design, UI, UX, etc. label May 26, 2021
@juliusknorr
Copy link
Member Author

Could be enough to just make sure the hide() is not called on .button-add but on the parent .actions.creatable in

server/core/src/OC/dialogs.js

Lines 322 to 325 in 3e624dc

var newButton = self.$filePicker.find('.actions.creatable .button-add')
if (type === self.FILEPICKER_TYPE_CHOOSE && !options.allowDirectoryChooser) {
newButton.hide()
}
but just a quick guess and not tested.

@szaimen szaimen added good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix. feature: filepicker labels Jun 23, 2021
@szaimen szaimen mentioned this issue Jul 17, 2021
Closed
@szaimen szaimen added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Jul 17, 2021
@szaimen
Copy link
Contributor

szaimen commented Jan 9, 2023

Hi, please update to 24.0.8 or better 25.0.2 and report back if it fixes the issue. Thank you!

@szaimen szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 2. developing Work in progress labels Jan 9, 2023
@juliusknorr
Copy link
Member Author

Seems fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug design Design, UI, UX, etc. feature: filepicker good first issue Small tasks with clear documentation about how and in which place you need to fix things in. needs info papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filepicker - hide empty create action box if creation is not allowed nextcloud/server
2 participants
@juliusknorr @szaimen