Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dav is never sending "update" imip emails when event is changed #12393

Closed
brad2014 opened this issue Nov 10, 2018 · 4 comments
Closed

dav is never sending "update" imip emails when event is changed #12393

brad2014 opened this issue Nov 10, 2018 · 4 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: dav

Comments

@brad2014
Copy link
Contributor

brad2014 commented Nov 10, 2018

When a calendar event is updated (e.g. its start time is changed), an update imip mail should be sent to attendees.

To reproduce:

  • create an event
  • add an attendee
  • notice invite email is received by attendee
  • change start time of event

Actual behavior:

  • attendee receives another "invite" email

Expected behavior:

  • attendee should receive an "update" email.
@brad2014
Copy link
Contributor Author

brad2014 commented Nov 10, 2018

Notes: According to RFC 5546,

The combination of the "UID" property (unchanged) and the "SEQUENCE" 
(bumped to 1) properties indicate the update.

But it looks like the code is incorrectly expecting METHOD to be REPLY instead of checking UID and SEQUENCE (I don't think the server should ever be sending an imip REPLY, only REQUEST and CANCEL. The client sends REPLY).

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #2249 (Updating dav fails), #1427 (Update sabre/dav), #7310 (Sending pgp encrypted Emails), #8385 (Cant set or change email), and #5658 (share by email - password email not sent - solved).

@skjnldsv skjnldsv added the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Jun 12, 2019
@georgehrke
Copy link
Member

@brad2014 Can you point us to the code you are talking about please?

In case of doubt this has to be fixed upstream at sabre/dav

@szaimen
Copy link
Contributor

szaimen commented May 26, 2021

I'm closing this issue due to inactivity. If this is still happening please make sure to upgrade to the latest version. After that, feel free to reopen.

@szaimen szaimen closed this as completed May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug feature: dav
Projects
None yet
Development

No branches or pull requests

5 participants