Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CalDAV birthday calendar: modifying birthdays should return 403 instead of 404 #11633

Closed
rfc2822 opened this issue Oct 5, 2018 · 6 comments · Fixed by #46225
Closed

CalDAV birthday calendar: modifying birthdays should return 403 instead of 404 #11633

rfc2822 opened this issue Oct 5, 2018 · 6 comments · Fixed by #46225
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 25-feedback bug feature: caldav Related to CalDAV internals feature: dav

Comments

@rfc2822
Copy link
Contributor

rfc2822 commented Oct 5, 2018

Currently, modifying birthday events in the birthday calendar (the one which is automatically created and filled with contact birthdays by Nextcloud) over CalDAV PUT returns HTTP 404 with this message:

<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception\NotFound</s:exception>
  <s:message>Node with name 'contacts-pas-id-565B107600000032.vcf.ics' could not be found</s:message>
</d:error>

(Reference: https://forums.bitfire.at/post/10439)

I think it would be better to return 403 Forbidden on PUT, because the iCalendar resource exists when downloading it. 404 would mean that there is no representation for this resource. With 403, clients and users can see that the resource is available, but cannot be modified.

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #8766 (Caldav ), #5077 (Propatch to birthday calendar returns 404), #8529 (NC 13: disable birthday calendar returns 302 with no feedback), #3003 (Disable birthday contacts calendar generation for user), and #10761 ([stable13] Fix call to OC.generateUrl for caldav birthday calendar on/off).

@skjnldsv
Copy link
Member

@georgehrke

@skjnldsv skjnldsv added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug needs info labels Jun 12, 2019
@georgehrke georgehrke self-assigned this Jun 12, 2019
@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info labels Jun 12, 2019
@georgehrke georgehrke added this to the Nextcloud 17 milestone Jun 12, 2019
@rullzer rullzer modified the milestones: Nextcloud 17.0.4, Nextcloud 17.0.5 Mar 11, 2020
@rullzer rullzer modified the milestones: Nextcloud 17.0.5, Nextcloud 17.0.6 Mar 23, 2020
@devvv4ever
Copy link

Short addition: If possible, it would be helpful if the error message could be more precise. Suggestion: "Contact birthdays is read-only. Please edit the contact itself to change this resource".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 25-feedback bug feature: caldav Related to CalDAV internals feature: dav
Projects
None yet
Development

Successfully merging a pull request may close this issue.