Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling to view files in folders generate excessive requests #10478

Closed
kimsyversen opened this issue Aug 1, 2018 · 2 comments
Closed

Scrolling to view files in folders generate excessive requests #10478

kimsyversen opened this issue Aug 1, 2018 · 2 comments
Labels

Comments

@kimsyversen
Copy link

This was identified on a default installation of Nextcloud 13.0.5 via Docker. I have noticed that one request per file is generated when

  1. You open a folder containing numerous files and you scroll to view the files
  2. You perform a search (e.g for txt or pdf) and you scroll to view the files

Sending one request for each file when scrolling seems overkill so I think there is room for improvement here.

Excerpt from access.log when scrolling is shown below.

[REDACTED] "GET /core/preview.png?file=%2Ftestfiles%2F314.txt&c=1692776fcfdea1fec564aaa0c53c00b7&x=64&y=64&forceIcon=0 HTTP/1.1" 200 [REDACTED] 
[REDACTED] "GET /core/preview.png?file=%2Ftestfiles%2F316.txt&c=f3a0c7838f81c0de7e226b7de513d854&x=64&y=64&forceIcon=0 HTTP/1.1" 200 [REDACTED] 
[REDACTED] "GET /core/preview.png?file=%2Ftestfiles%2F317.txt&c=9f43e8bf9aac411b71a0bb43120adff1&x=64&y=64&forceIcon=0 HTTP/1.1" 200 [REDACTED] 
[REDACTED] "GET /core/preview.png?file=%2Ftestfiles%2F328.txt&c=1cc7f7b36cb546a31062acfbe8bacb7d&x=64&y=64&forceIcon=0 HTTP/1.1" 200 [REDACTED] 
[REDACTED] "GET /core/preview.png?file=%2Ftestfiles%2F329.txt&c=0412659caef19f22626ca3f6e98f5e63&x=64&y=64&forceIcon=0 HTTP/1.1" 200 [REDACTED] 
[REDACTED] "GET /core/preview.png?file=%2Ftestfiles%2F339.txt&c=4019ac8f10b5d4a52623b8d1ed9d8292&x=64&y=64&forceIcon=0 HTTP/1.1" 200 [REDACTED] 
[REDACTED] "GET /core/preview.png?file=%2Ftestfiles%2F338.txt&c=bde60b2abf41b6123cb50afa0593c762&x=64&y=64&forceIcon=0 HTTP/1.1" 200 [REDACTED] 
[REDACTED] "GET /core/preview.png?file=%2Ftestfiles%2F458.txt&c=cfe4ab81fa418c40f1ed0c78733253ea&x=64&y=64&forceIcon=0 HTTP/1.1" 200 [REDACTED] 
[REDACTED] "GET /core/preview.png?file=%2Ftestfiles%2F459.txt&c=e6a762364031f0c5e91150d14747e72f&x=64&y=64&forceIcon=0 HTTP/1.1" 200 [REDACTED] 
[REDACTED] "GET /core/preview.png?file=%2Ftestfiles%2F463.txt&c=6053ed4b1939af53c4f997779df324c5&x=64&y=64&forceIcon=0 HTTP/1.1" 200 [REDACTED] 
[REDACTED] "GET /core/preview.png?file=%2Ftestfiles%2F462.txt&c=aa16b4d611a8826f7894969ce47ff72a&x=64&y=64&forceIcon=0 HTTP/1.1" 200 [REDACTED] 
[REDACTED] "GET /core/preview.png?file=%2Ftestfiles%2F465.txt&c=c3e06d906d891345117a34567130dacc&x=64&y=64&forceIcon=0 HTTP/1.1" 200 [REDACTED] 
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #2842 ([Files] Upload folders), #4149 (Moveing file/folder selection), #10073 (Kinetic scrolling in files for iOS), #1071 (Not possible to view files inside of Deleted Files), and #375 (Selectively encrypt files/folders).

@MorrisJobke
Copy link
Member

Sending one request for each file when scrolling seems overkill so I think there is room for improvement here.

That's how it works right now. We add an <img> with an URL and the browser then does the fetching. We don't plan to change this, because HTTP2 for example helps here a lot to reduce the overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants