-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add template renderas empty #10142
Labels
Comments
So then there are 3? I'd vote for "add constants and unify the usage", because f#$k magic strings 😎 |
And btw blank and empty are used since 4+ years:
|
Yes lets add them as constants! Also if they are there already we should exclude some js loading on blank and empty etc. |
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Richdocuments renders all their templates as
empty
. This is done because we embed the view in an iframe and we do not need the top bar etc etc.This works because the old code never checks the render as value as being one of the valid ones.
I'd vote to make this an official mode. And then also make sure that we kill javascript that doesn't belong there (for example the search stuff).
CC: @nickvergessen @MorrisJobke
The text was updated successfully, but these errors were encountered: