Do not load preview is version tab is not active

Signed-off-by: Louis Chemineau <louis@chmn.me>
nextcloud · Jun 20, 2023 · 2cfb3c8 · 2cfb3c8
1 parent f6be02e
commit 2cfb3c8
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/apps/files_versions/src/components/Version.vue b/apps/files_versions/src/components/Version.vue
@@ -17,20 +17,21 @@
  -->
 <template>
 	<div>
-		<NcListItem class="version"
+		<NcListItem v-if="loadPreview"
+			class="version"
 			:title="versionLabel"
 			:href="downloadURL"
 			:force-display-actions="true"
 			data-files-versions-version>
 			<template #icon>
-				<img v-if="(isCurrent || version.hasPreview) && !previewError"
+				<div v-if="!loadPreview" class="version__image" />
+				<img v-else-if="isCurrent || version.hasPreview"
 					:src="previewURL"
 					alt=""
 					decoding="async"
 					fetchpriority="low"
 					loading="lazy"
-					class="version__image"
-					@error="previewError = true">
+					class="version__image">
 				<div v-else
 					class="version__image">
 					<ImageOffOutline :size="20" />
@@ -185,13 +186,16 @@ export default {
 			type: Boolean,
 			default: false,
 		},
+		loadPreview: {
+			type: Boolean,
+			default: false,
+		},
 	},
 	data() {
 		return {
 			showVersionLabelForm: false,
 			formVersionLabelValue: this.version.label,
 			capabilities: loadState('core', 'capabilities', { files: { version_labeling: false, version_deletion: false } }),
-			previewError: false,
 		}
 	},
 	computed: {

diff --git a/apps/files_versions/src/views/VersionTab.vue b/apps/files_versions/src/views/VersionTab.vue
@@ -19,6 +19,7 @@
 	<ul data-files-versions-versions-list>
 		<Version v-for="version in orderedVersions"
 			:key="version.mtime"
+			:load-preview="isActive"
 			:version="version"
 			:file-info="fileInfo"
 			:is-current="version.mtime === fileInfo.mtime"
@@ -76,6 +77,11 @@ export default {
 				.map(version => version.mtime)
 				.reduce((a, b) => Math.min(a, b))
 		},
+
+		/** @return {boolean} */
+		isActive() {
+			return this.$parent.isActive
+		},
 	},
 	methods: {
 		/**