Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side by side comparison of document versions broken #3357

Closed
schiessle opened this issue Dec 12, 2023 · 6 comments · Fixed by nextcloud/viewer#2549
Closed

Side by side comparison of document versions broken #3357

schiessle opened this issue Dec 12, 2023 · 6 comments · Fixed by nextcloud/viewer#2549
Assignees
Labels
1. to develop Waiting for a developer bug Something isn't working

Comments

@schiessle
Copy link
Member

Describe the bug

I can no longer compare versions of a document side-by-side

To Reproduce
Steps to reproduce the behavior:

  1. Create a office document
  2. edit it multiple times
  3. close the document and go to the right sidebar
  4. got to versions
  5. click the "..." menu of one of the versions and chose "compare to current version"

Expected behavior
side-by-side read only view of the current version of the document and the selected version.

Instead the document opens full screen.

Tested with Hub7 on c.nc.com (worked with Hub6)

@juliushaertl juliushaertl added bug Something isn't working 1. to develop Waiting for a developer labels Dec 15, 2023
@juliushaertl
Copy link
Member

Quick styling fix could be this, but would probably be better to check on where this broke (likely with some upstream styling changes in viewer)

.viewer--split .office-viewer.viewer__file--active {
	width: 50%;

	&:nth-child(1) {
		left:0;
	}
	&:nth-child(2) {
		left:50%;
	}
}

@juliushaertl
Copy link
Member

In text it still works as expected

@joshtrichards
Copy link
Member

Another report in server: nextcloud/server#42714

@LCBdavid
Copy link

LCBdavid commented Jun 6, 2024

Issue still not resolved. I have to stay in v27 for this compare feature to work.
Please milestone this issue as we need it as it was working before and has been broke since v28.

@silviuchingaru
Copy link

Quick styling fix could be this, but would probably be better to check on where this broke (likely with some upstream styling changes in viewer)

.viewer--split .office-viewer.viewer__file--active {
	width: 50%;

	&:nth-child(1) {
		left:0;
	}
	&:nth-child(2) {
		left:50%;
	}
}

juliushaertl where to add that?
I realy need this feature... :-(

@juliushaertl
Copy link
Member

@elzody Maybe you can have a look. Would actually be nice to have visual regression checks with cypress-visual-regression like in the viewer app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Waiting for a developer bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants