Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album photo view shows some cropped images #1637

Closed
Daddy-ohh opened this issue Feb 13, 2023 · 4 comments
Closed

Album photo view shows some cropped images #1637

Daddy-ohh opened this issue Feb 13, 2023 · 4 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working

Comments

@Daddy-ohh
Copy link

Describe the bug
After clicking on an album, the photo viewer shows some cropped images.

To Reproduce
Steps to reproduce the behavior:

  1. Click Albums on the sidebar
  2. Click on an album
  3. Review the album photos for cropped images
  4. Click on a cropped image to view full size and see what it really looks like

Expected behavior
Display all images in album photo view as resized and uncropped

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Firefox
  • Version: 109.0.1

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Browser log

Open your console, reload your page and/or do the action leading to this issue and copy/paste the log in this thread.
[DEBUG] uploader: Destination path set to Photos to Print 2023-02-09 
Object { level: 0, app: "uploader", uid: "daddyohh" }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] uploader: Root path set to dav/photos/daddyohh/albums 
Object { level: 0, app: "uploader", uid: "daddyohh" }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] uploader: Context changed to 
Object { level: 0, app: "uploader", uid: "daddyohh", filename: "/photos/daddyohh/albums/Photos to Print 2023-02-09", basename: "Photos to Print 2023-02-09", lastmod: null, size: 0, type: "file", etag: null, mime: "", … }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] uploader: UploadPicker initialised 
Object { level: 0, app: "uploader", uid: "daddyohh" }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] photos: [TiledLayout] Computing rows 
Object { level: 0, app: "photos", uid: "daddyohh", items: (30) […] }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] photos: [VirtualScrolling] Computing visible rows 
Object { level: 0, app: "photos", uid: "daddyohh" }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
You need to fill either the text or the ariaLabel props in the button component. 
Object { text: null, ariaLabel: null }
 
Object { _uid: 2074, _isVue: true, __v_skip: true, _scope: {…}, "$options": {…}, _renderProxy: {…}, _self: {…}, "$parent": {…}, "$root": {…}, "$children": (1) […], … }
[ncvuecomponents.js:2:95826](webpack:///photos/node_modules/@nextcloud/vue/dist/ncvuecomponents.js)
[DEBUG] photos: [VirtualScrolling] Computing container 
Object { level: 0, app: "photos", uid: "daddyohh" }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] photos: [VirtualScrolling] Computing visible rows 
Object { level: 0, app: "photos", uid: "daddyohh" }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] photos: [TiledLayout] Computing rows 
Object { level: 0, app: "photos", uid: "daddyohh", items: (30) […] }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] photos: [VirtualScrolling] Computing visible rows 
Object { 0: {…}, 1: {…}, 2: {…}, 3: {…}, level: 0, app: "photos", uid: "daddyohh" }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] photos: [TiledLayout] Computing rows 
Object { level: 0, app: "photos", uid: "daddyohh", items: (30) […] }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] photos: [VirtualScrolling] Computing visible rows 
Object { 0: {…}, 1: {…}, 2: {…}, 3: {…}, level: 0, app: "photos", uid: "daddyohh" }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] photos: [Albums] Fetched 2 albums:  
Object { level: 0, app: "photos", uid: "daddyohh", data: (2) […] }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] uploader: Context changed to 
Object { level: 0, app: "uploader", uid: "daddyohh", filename: "/photos/daddyohh/albums/Photos to Print 2023-02-09", basename: "Photos to Print 2023-02-09", lastmod: null, size: 0, type: "file", etag: null, mime: "", … }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] photos: [TiledLayout] Computing rows 
Object { level: 0, app: "photos", uid: "daddyohh", items: (30) […] }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] photos: [VirtualScrolling] Computing visible rows 
Object { 0: {…}, 1: {…}, 2: {…}, 3: {…}, level: 0, app: "photos", uid: "daddyohh" }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)
[DEBUG] photos: [AlbumContent] Fetched 30 new files:  
Object { 0: "977697", 1: "977671", 2: "977674", 3: "717814", 4: "715350", 5: "556285", 6: "454985", 7: "429302", 8: "408992", 9: "341328", … }
[ConsoleLogger.js:52:10](webpack:///photos/node_modules/@nextcloud/logger/dist/ConsoleLogger.js)

​

<details>
<summary>How to access your browser console (Click to expand)</summary>

# Chrome
- Press either CTRL + SHIFT + J to open the “console” tab of the Developer Tools.
- Alternative method:
    1. Press either CTRL + SHIFT + I or F12 to open the Developer Tools.
    2. Click the “console” tab.

# Safari
- Press CMD + ALT + I to open the Web Inspector.
- See Chrome’s step 2. (Chrome and Safari have pretty much identical dev tools.)

# IE9
1. Press F12 to open the developer tools.
2. Click the “console” tab.

# Firefox
- Press CTRL + SHIFT + K to open the Web console (COMMAND + SHIFT + K on Macs).
- or, if Firebug is installed (recommended):
    1. Press F12 to open Firebug.
    2. Click on the “console” tab.

# Opera
1. Press CTRL + SHIFT + I to open Dragonfly.
2. Click on the “console” tab.
</details>

**Additional context**
![Image1](https://user-images.githubusercontent.com/93015741/218588632-2c31db58-9d68-40ea-afe0-91edec72286a.jpg)

Add any other context about the problem here.
![Image1](https://user-images.githubusercontent.com/93015741/218588791-7490f2e2-854e-4f6b-8b7a-066cf8bfad58.jpg)

@Daddy-ohh Daddy-ohh added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Feb 13, 2023
@joshtrichards
Copy link
Member

Hi @Daddy-ohh - Do you perhaps have Enable square photos view toggled on in your Photos settings? If I'm understanding your report that is what this behavior sounds a lot like.

If so, change that setting and close out this Issue. :-)

@Daddy-ohh
Copy link
Author

Enable square photos view is not toggled on.

@joshtrichards
Copy link
Member

joshtrichards commented Jul 16, 2023

Okay. I now see what you're saying. (I also just noticed you provided screenshots in your original report. Thank you. I didn't see them the first time around since they're embedded in your preformatted text and thus did not display automatically).

Right now the two overview modes are basically "very cropped" and "semi/sometimes cropped". It sounds like you want a 100% uncropped (but resized is fine) overview page.

I'd say this is an enhancement not a bug.

@Daddy-ohh
Copy link
Author

Thanks for the clarification - closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants