[Bug] The final download attempt always crashes

[falghamdi125]

Hello everyone,

There is a bug in the app causing it to crash, and the final download attempt consistently fails. This seems to occur because the share is removed before the download begins. I'm unsure if it would be better to register the app and start counting attempts before or after initiating the download process. Currently, it appears that the attempts are being counted before the download process starts.

Steps to reproduce

1. Create a share with 2 download limit
2. Copy the link and paste it into the browser address bar to open it
3. Click the Download button in the header for the first time to initiate the download. No problem so far.
4. Click the Download button in the header again (last attempt), and you will notice the download fails because the share has been removed.

Expected behaviour

1. For the last allowed attempt, downloading the file should start fine.
2. The share should be removed after downloading is initiated.

Actual behaviour

Download fails.

Server configuration

Web server: Nginx

Database: MySQL

PHP version: 8.2

Nextcloud version: master

files_downloadlimit version: master

Best