Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ignoring users who unshared from a calendar #100

Closed
tcitworld opened this issue Jun 17, 2024 · 3 comments · Fixed by #106
Closed

Support ignoring users who unshared from a calendar #100

tcitworld opened this issue Jun 17, 2024 · 3 comments · Fixed by #106
Labels
bug Something isn't working

Comments

@tcitworld
Copy link
Member

nextcloud/server#43117 brings a new share type which needs to be taken into account.

@tcitworld tcitworld added the bug Something isn't working label Jun 17, 2024
@tcitworld
Copy link
Member Author

What we need is the list of unshares for a calendar, so that we can remove them from the list of users computed from the group shares.

As far as I can see there's no way to get the list of shares including the unshares, so this needs server changes. I would either :

  • getSharesForId to have an optional parameter to include unshares
  • add a new method to get specifically unshares

Do you have some input @miaulalala ?

@nickvergessen
Copy link
Member

I'll have a look

@miaulalala
Copy link

What we need is the list of unshares for a calendar, so that we can remove them from the list of users computed from the group shares.

As far as I can see there's no way to get the list of shares including the unshares, so this needs server changes. I would either :

* `getSharesForId` to have an optional parameter to include unshares

* add a new method to get specifically unshares

Do you have some input @miaulalala ?

I like the unshares method. Optional params are not my fave code construct. OTOH having one query instead of two is a legitimate thought. I leave the implementation details up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants