Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elements with missing roles #3822

Closed
3 tasks done
juliusknorr opened this issue May 13, 2022 · 4 comments · Fixed by #3986
Closed
3 tasks done

Elements with missing roles #3822

juliusknorr opened this issue May 13, 2022 · 4 comments · Fixed by #3986
Labels
1. to develop accessibility bug

Comments

@juliusknorr
Copy link
Member

juliusknorr commented May 13, 2022 •
edited
Loading

  • Sidebar button in top right is missing an accessible name
  • Expand button in the app navigation is missing a name
    • should use aria-expanded
@juliusknorr juliusknorr moved this to 📄 To do (5-20 entries) in 📝 Office team May 13, 2022
@marcelklehr marcelklehr mentioned this issue Aug 19, 2022
Merged
4 tasks
@marcelklehr
Copy link
Member

marcelklehr commented Aug 19, 2022 •
edited
Loading

The expand button is fixed in latest nc vue. see https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/NcAppNavigationItem/NcAppNavigationItem.vue#L133

Repository owner moved this from 📄 To do (~10 entries) to ☑️ Done in 📝 Office team Aug 19, 2022
@marcelklehr marcelklehr reopened this Aug 19, 2022
@marcelklehr marcelklehr removed their assignment Oct 18, 2022
@juliusknorr juliusknorr moved this from ☑️ Done to 📄 To do (~10 entries) in 📝 Office team Oct 20, 2022
@JuliaKirschenheuter
Copy link
Contributor

Is this issue still open?

@marcelklehr
Copy link
Member

Technically yes as the expand button in Nextcloud/vue doesn't have an aria-expanded when I last checked

@juliusknorr
Copy link
Member Author

It has been added with nextcloud-libraries/nextcloud-vue@eb4735e and I just verified that it is there also with the latest deck release.

Repository owner moved this from 📄 To do (~10 entries) to ☑️ Done in 📝 Office team Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop accessibility bug
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a11y label for sidebar button nextcloud/deck
3 participants
@marcelklehr @juliusknorr @JuliaKirschenheuter