Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cannot rename Deck List #3633

Closed
5 of 8 tasks
toneldaclan opened this issue Mar 11, 2022 · 6 comments · Fixed by #3670
Closed
5 of 8 tasks

[Bug]: Cannot rename Deck List #3633

toneldaclan opened this issue Mar 11, 2022 · 6 comments · Fixed by #3670
Labels

Comments

@toneldaclan
Copy link

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

Cannot rename Deck List after updating Deck 1.6.0 to Deck 1.6.1

Steps to reproduce

  1. Go to Deck
  2. Select a Board and rename a List by double-clicking the List Name
  3. Renaming fails

Expected behavior

The List can be renamed by Users who can manage the Board.

Installation method

Manual installation

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.0

Web server

Nginx

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a minor version (ex. 22.2.3 to 22.2.4)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

system
{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "cloud.deltaearthmoving.com",
            "192.168.8.236"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "23.0.2.1",
        "overwrite.cli.url": "https:\/\/cloud.deltaearthmoving.com",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "activity_expire_days": 14,
        "auth.bruteforce.protection.enabled": true,
        "blacklisted_files": [
            ".htaccess",
            "Thumbs.db",
            "thumbs.db",
            "@eaDir"
        ],
        "cron_log": true,
        "default_phone_region": "PH",
        "defaultapp": "files,dashboard",
        "enable_previews": true,
        "enabledPreviewProviders": [
            "OC\\Preview\\PNG",
            "OC\\Preview\\JPEG",
            "OC\\Preview\\GIF",
            "OC\\Preview\\BMP",
            "OC\\Preview\\XBitmap",
            "OC\\Preview\\Movie",
            "OC\\Preview\\PDF",
            "OC\\Preview\\MP3",
            "OC\\Preview\\TXT",
            "OC\\Preview\\MarkDown"
        ],
        "filesystem_check_changes": 0,
        "filelocking.enabled": "true",
        "htaccess.RewriteBase": "\/",
        "integrity.check.disabled": false,
        "knowledgebaseenabled": false,
        "logfile": "\/var\/log\/nextcloud\/nextcloud.log",
        "loglevel": "2",
        "logtimezone": "Asia\/Manila",
        "log_rotate_size": "104857600",
        "maintenance": false,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "overwriteprotocol": "https",
        "preview_max_x": 1024,
        "preview_max_y": 768,
        "preview_max_scale_factor": 1,
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0,
            "timeout": 0,
            "dbindex": 0
        },
        "quota_include_external_storage": false,
        "share_folder": "\/Shares",
        "skeletondirectory": "",
        "theme": "",
        "trashbin_retention_obligation": "auto, 7",
        "updater.release.channel": "stable",
        "remember_login_cookie_lifetime": "1800",
        "versions_retention_obligation": "auto, 365",
        "simpleSignUpLink.shown": false,
        "upgrade.disable-web": true,
        "log.condition": {
            "apps": [
                "admin_audit"
            ]
        },
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpauth": 1,
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "587"
    }
}

List of activated Apps

Enabled:
  - accessibility: 1.9.0
  - activity: 2.15.0
  - admin_audit: 1.13.0
  - analytics: 4.1.1
  - announcementcenter: 6.1.1
  - approval: 1.0.9
  - breezedark: 23.2.1
  - bruteforcesettings: 2.3.0
  - calendar: 3.2.0
  - circles: 23.0.1
  - cloud_federation_api: 1.6.0
  - comments: 1.13.0
  - contacts: 4.0.8
  - contactsinteraction: 1.4.0
  - dashboard: 7.3.0
  - dav: 1.21.0
  - deck: 1.6.1
  - drawio: 1.0.2
  - external: 3.10.2
  - extract: 1.3.3
  - federatedfilesharing: 1.13.0
  - federation: 1.13.0
  - file_sharing_invalid_notifier: 0.1.1
  - files: 1.18.0
  - files_accesscontrol: 1.13.0
  - files_automatedtagging: 1.13.0
  - files_downloadactivity: 1.12.0
  - files_downloadlimit: 0.1.3
  - files_markdown: 2.3.5
  - files_pdfviewer: 2.4.0
  - files_retention: 1.12.0
  - files_rightclick: 1.2.0
  - files_sharing: 1.15.0
  - files_trashbin: 1.13.0
  - files_versions: 1.16.0
  - files_videoplayer: 1.12.0
  - fileslibreofficeedit: 1.0.4
  - forms: 2.4.0
  - group_default_quota: 0.1.3
  - groupfolders: 11.1.2
  - groupquota: 0.1.7
  - logreader: 2.8.0
  - lookup_server_connector: 1.11.0
  - mail: 1.11.7
  - metadata: 0.15.0
  - nextcloud_announcements: 1.12.0
  - notes: 4.3.1
  - notifications: 2.11.1
  - notify_push: 0.3.0
  - oauth2: 1.11.0
  - password_policy: 1.13.0
  - photos: 1.5.0
  - privacy: 1.7.0
  - provisioning_api: 1.13.0
  - quickaccesssorting: 1.1.3
  - quota_warning: 1.13.1
  - ransomware_protection: 1.12.0
  - recommendations: 1.2.0
  - richdocuments: 5.0.3
  - richdocumentscode: 21.11.204
  - serverinfo: 1.13.0
  - settings: 1.5.0
  - sharebymail: 1.13.0
  - spreed: 13.0.3
  - support: 1.6.0
  - systemtags: 1.13.0
  - tasks: 0.14.2
  - text: 3.4.0
  - theming: 1.14.0
  - theming_customcss: 1.10.0
  - twofactor_backupcodes: 1.12.0
  - updatenotification: 1.13.0
  - user_status: 1.3.1
  - viewer: 1.7.0
  - weather_status: 1.3.0
  - workflow_script: 1.8.0
  - workflowengine: 2.5.0
Disabled:
  - electronicsignatures: 1.10.1
  - encryption
  - files_external
  - files_lock: 20.1.0
  - firstrunwizard: 2.12.0
  - openotp_sign: 1.2.1
  - richdocumentscode_arm64
  - side_menu: 2.3.3
  - survey_client: 1.11.0
  - terms_of_service: 1.9.3
  - user_ldap

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Additional info

No response

@szaimen szaimen transferred this issue from nextcloud/server Mar 11, 2022
@stefan-niedermann
Copy link
Member

What do you mean with

Renaming fails

? Is there an error message? A red border or an exclamation mark? Is the input not editable at all? Does the new entered list title stay or revert to the old one? ...?

Was it possible for you to rename a list in a previous version?

Please try to be more verbose when describing a bug, we can't see what you see 😉

What is the log of the browser console? (Press F12 and switch to the Console tab)

@Milokita
Copy link

Milokita commented Mar 14, 2022

I encountered the same error using the same setup except I used apache2. The bug is reproducible on another docker fresh install.

Is there an error message? A red border or an exclamation mark?

There is no error message on the webpage.

Is the input not editable at all? Does the new entered list title stay or revert to the old one? ...?

The input is still editable but the title stays after entering

Looking into the console shows the a '403 Forbidden' with response like this:
{"status":403,"message":"Permission denied"}
However, no 403 error is found in apache2 error log

The deck app from F-droid showed a more detailed error info, but the key message is still permission denied.

@toneldaclan
Copy link
Author

What do you mean with

Renaming fails

? Is there an error message? A red border or an exclamation mark? Is the input not editable at all? Does the new entered list title stay or revert to the old one? ...?

Was it possible for you to rename a list in a previous version?

Please try to be more verbose when describing a bug, we can't see what you see wink

What is the log of the browser console? (Press F12 and switch to the Console tab)

As descried by @Milokata, I can enter into the edit box but the List Name reverts when I press enter. I can properly rename on the previous version. This only happened when I upgraded to Deck 1.6.1 from Deck 1.6.0. No error message was encountered.

@reox
Copy link
Contributor

reox commented Mar 15, 2022

I see an error 500 in the browser JS console when renaming a stack:

PUT https://xxx/apps/deck/stacks/63   error 500


Uncaught (in promise) Error: Request failed with status code 500
    exports createError.js:16
    exports settle.js:17
    onreadystatechange xhr.js:62
    exports xhr.js:34
    exports xhr.js:13
    exports dispatchRequest.js:50
    promise callback*30321/l.prototype.request Axios.js:61
    t Axios.js:87
    exports bind.js:9
    value StackApi.js:119
    updateStack stack.js:103
    v vuex.esm.js:741
    dispatch vuex.esm.js:505
    dispatch vuex.esm.js:397
    finishedEdit Stack.vue:180
    submit Stack.vue:1

NC running behind a reverse proxy, using nginx on the nextcloud host. NC 23.0.2 / Deck 1.6.1

edit: This is very funny. Now I see also a 403 in the log:

PUT https://xxx/apps/deck/stacks/45
[[HTTP/2 403 Forbidden 83ms]]()

Uncaught (in promise) Error: Request failed with status code 403
    exports createError.js:16
    exports settle.js:17
    onreadystatechange xhr.js:62
    exports xhr.js:34
    exports xhr.js:13
    exports dispatchRequest.js:50
    promise callback*30321/l.prototype.request Axios.js:61
    t Axios.js:87
    exports bind.js:9
    value StackApi.js:119
    updateStack stack.js:103
    v vuex.esm.js:741
    dispatch vuex.esm.js:505
    dispatch vuex.esm.js:397
    finishedEdit Stack.vue:180
    submit Stack.vue:1

Not sure why that changed though. I only upgraded to 23.0.3 yesterday.

@oneWaveAdrian
Copy link
Contributor

oneWaveAdrian commented Mar 15, 2022

Can confirm, dev console show request returns 403

Request

Request URL: https://[URL redacted]/apps/deck/stacks/83
Request Method: PUT

Payload

ETag: "cfcd208495d565ef66e7dff9f98764da"
boardId: 20
deletedAt: 0
id: 83
lastModified: 0
order: 2
title: "FE Event"

Response

message: "Permission denied"
status: 403
  • Creating new lists with same user works.
  • User has admin rights, so actual permission error is unlikely.

@juliusknorr
Copy link
Member

Fix is in #3670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants