Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user Comments #8

Open
poltrian opened this issue Jun 12, 2019 · 10 comments
Open

Add user Comments #8

poltrian opened this issue Jun 12, 2019 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@poltrian
Copy link

poltrian commented Jun 12, 2019

Hi,
comment like stars or Like, or better you can write something "worst ever" "love" "you could add ... to ... make it better

@mrzapp mrzapp added the enhancement New feature or request label Jul 11, 2019
@mrzapp
Copy link
Contributor

mrzapp commented Jul 12, 2019

@poltrian Yeah, could be neat. Comments are actually supported in the schema.org standard. We can use the NextCloud user credentials for the user information.

@Teifun2
Copy link
Collaborator

Teifun2 commented Nov 30, 2019

Where would you add the user credentials to a comment? to author or maybe a different schema field?

@mrzapp
Copy link
Contributor

mrzapp commented Nov 30, 2019

@Teifun2 the schema.org standard has a "comment" field we could use

@Teifun2
Copy link
Collaborator

Teifun2 commented Nov 30, 2019

@mrzapp Yes i did see that. But if we want to store the credentials of the user + its comments, how do we do this? According to schema.org a Comment can have a Text (which would be the actual comment?) but what field would contain the user credentials? author?

 "recipeIngredient": [
    "1/4 cup oil",
    "1/4 cup water"
  ],
  "recipeInstructions": [
    "Step1: Step1."
  ],
  "commentCount": 1,
  "comment": [
    {
      "@type": "Comment",
      "text": "I Rate this recipe ....",
      "author": [
      	"@type": "Author".
      	"additionalName": "Username101",
      	"identifier": "UserId?"
      ]
    }
  ],

@mrzapp
Copy link
Contributor

mrzapp commented Nov 30, 2019

@Teifun2 exactly, the author field is meant for that. Your proposal is exactly how I would do it too.

@Teifun2
Copy link
Collaborator

Teifun2 commented Dec 5, 2019

Although i think this is a very good feature i would leave it aside for the moment and first focus on #116 #47 and potentially #11 . I think the aspect of storing your own recipes and using them should be the main task. Sharing and collaborative work can come when the individuals database is at a certain level.

@mrzapp mrzapp added this to the v0.7.0 milestone Dec 5, 2019
@spikusmax
Copy link

I second this one. One could use the tagging to indicate stars already but it would be nice for that the be represented visually. I would really like to see dated comments that would enable technical notes. E.g. "needs 60min cooking not 45 in our shitty oven". Less worried about the collaborative side of comments.

@mrzapp mrzapp modified the milestones: v0.7.0, v0.8.0 Mar 27, 2020
@Mannshoch
Copy link

May if you Update a Cooking step a popup appear which request to check if comments are out of date and could be removed.

@christianlupus
Copy link
Collaborator

This is related to #323, #342 and potentially #364.

@GutHib
Copy link

GutHib commented Jan 22, 2021

"needs 60min cooking not 45 in our shitty oven"

This. Or comments like:

"Jan. 21: Used ordinary onion instead of scallion, and butternut pumpkin instead of hokkaido. Pumpkin took a bit longer to soften, but turned out great." Or:

"For some reason, meat turned out tough. Screw the supermarket. Buy at the butcher next time. Also, try less heat."

For me, keeping track of success and failure is an important part of recipe evolution - it's what helps you improve. To me, this isn't related to rating or collaboration - just a simple area for private notes.

Probably, comment field would be best at the bottom (after all, that's where you'd scribble manual notes on a printed recipe).

[Of course, if everyone could arrange order to their liking, that would be even better, but let's not be too greedy now. :-)) ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

7 participants