Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a group to a circle makes it "readonly" for the owner #973

Closed
marcotrevisan opened this issue Mar 23, 2022 · 8 comments · Fixed by #999
Closed

Adding a group to a circle makes it "readonly" for the owner #973

marcotrevisan opened this issue Mar 23, 2022 · 8 comments · Fixed by #999

Comments

@marcotrevisan
Copy link

marcotrevisan commented Mar 23, 2022

Version: 22.3 (just upgraded NC server from 22.2.5 to 22.2.6)

STEPS TO REPRO

  • Create a new circle
  • [UPDATED] Add a group to that circle (I mean a group in the "Users" page, not a group created in the Circles app) that contains tha current user
  • Navigate in another app i.e. Calendar
  • Go back to circles and select the just created circle

EXPECTED BEHAVIOUR
The user can add/remove groups and members as usual

OBSERVED BEHAVIOUR
The UI changes as if the current user is not the owner of the circle anymore.
Until before upgrading NC server I was able to edit any circle I created.

Schermata 2022-03-23 alle 08 14 04

@marcotrevisan
Copy link
Author

marcotrevisan commented Mar 26, 2022

I upgraded to NC 23 the instance on which I filed this issue.
The behaviour has unfortunately not changed. However I found what is perhaps causing it:

  • The group added to the circle includes myself (the owner)
  • If I click on the "Leave circle" action and refresh the page, the circle shows up and is back to editable.

So perhaps the root cause is that the UI is checking my belonging to the group and forgets to check that I'm also the owner of the circle.

(Edited the issue description)

@maximelehericy
Copy link

Same issue here, with NC 22.2.5

WHEN User A is owner of the circle C
AND User A belongs to Group Z
AND Group Z is added to the circle C
THEN User A has no longer owner permissions on the circle C

@XueSheng-GIT
Copy link

XueSheng-GIT commented Apr 2, 2022

I can confirm this issue on NC 23.0.3. Any workaround yet?

UPDATE: This also affects the access rights to e.g. collectives (read only for the owner after adding a group which owner belongs to).

@ArtificialOwl
Copy link
Member

It seems it only affect group, not sub-circles ?

@marcotrevisan
Copy link
Author

Just tested. The same behaiour holds if you add another circle instead of a group.
To see the effect on the available UI controls you need to reload the page.

@ArtificialOwl
Copy link
Member

Strange, can you describe the process to reproduce this issue with a sub circles ?

This is me, reproducing the issue with group:
Selection_028

1 means Member level

And with a sub-circles:

Selection_029

9 means Owner level

@marcotrevisan
Copy link
Author

Thanks for your further feedback @ArtificialOwl. I testeed more thoroughly and I wasn't aware of a subtle condition that is actually triggering it.

If, using only the Contacts app, I create Circle 1, then Circle 2 (so I'm the owner of both) and then add Circle 2 to 1 or vice versa, it works.
But, if say Circle 1 is associated to a Collective, then adding Circle 2 (that contains me as owner) to it triggers the issue.

As a Collectives administrator user this behaviour is unwanted because it forces me to add people one by one to the circle instead of reusing my existing groups.

@ArtificialOwl
Copy link
Member

#999 should fix this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants