Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar Icon missing in menu #368

Closed
ghost opened this issue Mar 15, 2017 · 28 comments · Fixed by #369
Closed

Calendar Icon missing in menu #368

ghost opened this issue Mar 15, 2017 · 28 comments · Fixed by #369
Assignees
Labels
3. to review Waiting for reviews bug

Comments

@ghost
Copy link

ghost commented Mar 15, 2017

Steps to reproduce

  1. Nextcloud instance with calendar-app

Expected behaviour

Icon is visible

Actual behaviour

Icon is not shown

Server configuration

Operating system: CentOS

Web server: Apache 2.2

Database: MySQL

PHP version: 7.0.8

Server version: 11.0.2

Calendar version: 1.5.1

Updated from an older installed version or fresh install: Updated from 1.5.0

Login as admin user into your cloud and access 
http://example.com/index.php/settings/integrity/failed 
paste the results here:
`No errors have been found.`

List of activated apps:
Enabled:

  • calendar: 1.5.1
  • contacts: 1.5.3
  • dav: 1.1.1
  • direct_menu: 0.10.0
  • federatedfilesharing: 1.1.1
  • files: 1.6.1
  • files_pdfviewer: 1.0.1
  • files_sharing: 1.1.1
  • files_texteditor: 2.2
  • files_trashbin: 1.1.0
  • files_videoplayer: 1.0.0
  • gallery: 16.0.0
  • logreader: 2.0.0
  • lookup_server_connector: 1.0.0
  • nextcloud_announcements: 1.0
  • notifications: 1.0.1
  • password_policy: 1.1.0
  • provisioning_api: 1.1.0
  • sharebymail: 1.0.1
  • spreed: 1.2.0
  • theming: 1.1.1
  • twofactor_backupcodes: 1.0.0
  • updatenotification: 1.1.1
  • workflowengine: 1.1.1

Disabled:

  • activity
  • admin_audit
  • comments
  • encryption
  • external
  • federation
  • files_accesscontrol
  • files_automatedtagging
  • files_external
  • files_retention
  • files_versions
  • firstrunwizard
  • serverinfo
  • survey_client
  • systemtags
  • templateeditor
  • user_external
  • user_ldap
  • user_saml

**The content of config/config.php:**
{
    "system": {
        "instanceid": "oczlzc627zwt",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***"                                            ,
        "dbtype": "mysql",
        "version": "11.0.2.7",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "localhost",
        "dbport": "",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "logtimezone": "UTC",
        "installed": true,
        "loglevel": 3,
        "updater.release.channel": "stable",
        "filelocking.enabled": "true",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0,
            "timeout": 0
        },
        "maintenance": false,
        "theme": ""
    }
}

Are you using encryption: no

Client configuration

Browser: Firefox

Operating system: Win8.1

@ghost
Copy link
Author

ghost commented Mar 15, 2017

The problem I found was the path for the svg-icon as shown in the following screenshot:

missing-icon

Only the calendar app is missing the nextcloud (part of the path). All other apps start with nextcloud/restOfPath/

@georgehrke
Copy link
Member

That's really weird, because contacts and calendar use exactly the same routine to generate the path:
https://github.com/nextcloud/calendar/blob/master/appinfo/application.php#L102
https://github.com/nextcloud/contacts/blob/master/appinfo/app.php#L35

@georgehrke
Copy link
Member

Though it's weird that the contacts app uses a callback oO

@ghost
Copy link
Author

ghost commented Mar 15, 2017

The same problem appears with the standard-menu. So it's not a problem of the direct-menu-app.

@georgehrke
Copy link
Member

@georgehrke georgehrke added 1. to develop Accepted and waiting to be taken care of bug labels Mar 15, 2017
@georgehrke georgehrke added this to the 1.6.0-current milestone Mar 15, 2017
@georgehrke georgehrke self-assigned this Mar 15, 2017
@georgehrke georgehrke added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Mar 15, 2017
@georgehrke
Copy link
Member

@bastoGrande Do you mind to help testing #369 ? :)

@georgehrke georgehrke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 15, 2017
@ghost
Copy link
Author

ghost commented Mar 15, 2017

Well, I guess I can try, but don't know how? :)

@georgehrke
Copy link
Member

you can test this by replacing the content of apps/calendar/appinfo/application.php with the content of https://raw.githubusercontent.com/nextcloud/calendar/9b6db3b4aad3ebfd85057e0e0456dac2a6252056/appinfo/application.php :)

@tcitworld
Copy link
Member

Don't see why updating from 1.5.0 would have changed this. Even more, it's correctly shown on all of my instances with the same configuration.

@ghost
Copy link
Author

ghost commented Mar 15, 2017

well I replaced it and did a "ctrl+f5" refresh and the icon is still missing... :S

@ghost
Copy link
Author

ghost commented Mar 15, 2017

@tcitworld
That's actually a good point. I couldn't imagine to be the first and only one, who is experiencing it, but forgot to write it...

@georgehrke
Copy link
Member

well I replaced it and did a "ctrl+f5" refresh and the icon is still missing... :S

Hm. :/

The problem is that neither @tcitworld nor me can reproduce your bug :/

@ghost
Copy link
Author

ghost commented Mar 15, 2017

I just tried to edit in the browser the path of the icon. Nothing happened, so where is the icon supposed to be? Under what path can I normally find it?

@georgehrke
Copy link
Member

Under what path can I normally find it?

It's supposed to be inside apps/calendar/img/calendar.svg

@georgehrke
Copy link
Member

Does this file exist in your Nextcloud installation? :)

@ghost
Copy link
Author

ghost commented Mar 15, 2017

sorry.. just had to get to the beach. it was about time, since the last time! 🙂

so yes, the file apps/calendar/img/calendar.svg exist. after downloading it, I tried to open it with Inkscape, but didn't work, well at least I didnt't see anything that looks like logo.. so that's why I think, somehow my icon-file got corrupted.. anyone an idea?

so i will try to get the original from the repository and check if this changes something or maybe there is another problem with my Inkscape installation..
weird day, today.. 😕

@ghost
Copy link
Author

ghost commented Mar 15, 2017

well it didn't got corrupted (same content), but what the heck is going on?
I can't open the calendar.svg correctly with my Inkscape installation. No error appears, but no logo is shown as well.
Can anyone confirm?

Because I already successfully worked with Inkscape and had no problems before.

@ghost
Copy link
Author

ghost commented Mar 16, 2017

well I still don't have an idea what exactly is going wrong.

  1. can anybody try to open the calendar.svg and confirm to see the calendar symbol?
  2. can anybody me show/tell what img-path he/she has in his/her functioning nc-instance?

thx!

@georgehrke
Copy link
Member

can anybody try to open the calendar.svg and confirm to see the calendar symbol?

I see the (white) calendar icon

can anybody me show/tell what img-path he/she has in his/her functioning nc-instance?

it's apps/calendar/img/calendar.svg for me

@ghost
Copy link
Author

ghost commented Mar 16, 2017

it's apps/calendar/img/calendar.svg for me

well, that's great, because it is the same for me

I see the (white) calendar icon

mhm, that's not so great.. what program do you use to open it? I tried paint.net (with plugin) and Inkscape and both didn't show me anything with the svg from my instance and the one from the repository.

@georgehrke
Copy link
Member

well, that's great, because it is the same for me

Well, because my nextcloud instance is in http://nextcloud.dev/index.php
So that's the expected behavior

mhm, that's not so great.. what program do you use to open it? I tried paint.net (with plugin) and Inkscape and both didn't show me anything with the svg from my instance and the one from the repository.

Sketch on macOS. I can also just open the svg in Firefox / Chromium and Safari

@georgehrke
Copy link
Member

files - nextcloud chromium today at 9 15 29 pm

and if i move nextcloud to a subfolder, the path to the svg changes as well. Just as expect.

@ghost
Copy link
Author

ghost commented Mar 16, 2017

well, what could be the problem, that this recognition fails? because i have installed my nextcloud-instance into a subfolder.
could it be that #358 could break this recognition (cause this was another bug I experienced)? (I don't think so, but who knows?)

@georgehrke
Copy link
Member

could it be that #358 could break this recognition

No, it's very very very very unlikely that these bugs are related.

@ghost
Copy link
Author

ghost commented Mar 16, 2017

No, it's very very very very unlikely that these bugs are related.

ok

well, what could be the problem, that this recognition fails?

@georgehrke
Copy link
Member

georgehrke commented Mar 16, 2017

I guess it's some configuration issue on your side, but that's only a wild guess.
Actually I'm really clueless at the moment. It's also not related to Firefox on Windows either:
dashboard firefox today at 10 14 28 pm

I tried different configurations but I had no luck reproducing your issue.

@ghost
Copy link
Author

ghost commented Mar 16, 2017

well, it's just an icon.. I'll try to forget it.. thank you for your effort!
I learnt a lot and I think that is the point what we should keep in mind about this "bug"...

@ghost
Copy link
Author

ghost commented Mar 20, 2017

hehe, one big 🤦‍♂️ (offtopic: why is there no man-facepalm, but a woman with a mars-gender-symbol?!?) for me!

I just never thought it could be a caching problem, but I don't know why I never thought about it, because now it's super obvious to me!
Found the hint here..

You can forget this never existing bug and thanks again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants