Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving events back and forth between calendars causes trash bin conflicts #3325

Closed
raimund-schluessler opened this issue Jul 13, 2021 · 4 comments · Fixed by nextcloud/server#30120
Assignees
Labels
2. developing Work in progress bug priority regression Regression of a previous working feature

Comments

@raimund-schluessler
Copy link
Member

Moving an event to a different calendar B and back to the original calendar A is broken at the moment, because the original event is still present in calendar A due to how the trash bin works. See nextcloud/tasks#1685 for the original report.

@raimund-schluessler raimund-schluessler added bug 0. to triage Pending approval or rejection 1. to develop Accepted and waiting to be taken care of and removed 0. to triage Pending approval or rejection labels Jul 13, 2021
@raimund-schluessler raimund-schluessler added this to the v2.3.1 milestone Jul 13, 2021
@raimund-schluessler raimund-schluessler added regression Regression of a previous working feature priority labels Jul 13, 2021
@ChristophWurst ChristophWurst changed the title Moving events back and forth between calendars is broken Moving events back and forth between calendars causes trash bin conflicts Jul 14, 2021
@ChristophWurst ChristophWurst modified the milestones: v2.3.1, 2.3.2 Jul 14, 2021
@tcitworld
Copy link
Member

Shouldn't this be a server issue then?

@ChristophWurst
Copy link
Member

depends on how moving works. I haven't checked the code yet.

@raimund-schluessler
Copy link
Member Author

Shouldn't this be a server issue then?

I guess this depends on what is intended here. There are multiple solutions and I am not sure what is the most logical one.

My tendency is to say that moving events should not create a trash bin entry, since the event is not deleted. This would restore compatibility with all clients. In that case, it's a Server issue.

@gohrner
Copy link

gohrner commented Dec 4, 2021

My tendency is to say that moving events should not create a trash bin entry, since the event is not deleted. This would restore compatibility with all clients. In that case, it's a Server issue.

Note that a client which support multiple server connections may also move an event from one calender on one server to another calendar on a completely different server, of which the first server does not know anything.

This will look like a "delete" for the first server.

I'd vote for allowing to silently overwrite events in the trashbin, which also then restores the events from the trashbin.

This will fix the protocol for all clients, I'd presume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug priority regression Regression of a previous working feature
Projects
Development

Successfully merging a pull request may close this issue.

5 participants