Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exit if rsync fails #6028

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

exit if rsync fails #6028

wants to merge 1 commit into from

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Feb 11, 2025

Close #6014

@szaimen
exit if rsync fails
4842fc1 
Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen added 2. developing Work in progress enhancement New feature or request labels Feb 11, 2025
@szaimen szaimen added this to the next milestone Feb 11, 2025
@szaimen szaimen mentioned this pull request Feb 11, 2025
Open
szaimen
szaimen commented Feb 11, 2025
View reviewed changes
Containers/nextcloud/entrypoint.sh
@@ -217,6 +217,8 @@ if ! [ -f "$NEXTCLOUD_DATA_DIR/skip.update" ]; then
fi

echo "Initializing nextcloud $image_version ..."
# TODO: touch rsync file to track what happens so that the container does not continue restarting? (it is not known what happens if it fails here at this step)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshtrichards I need help with this. What should happen if we actually exit here? should we just touch a file so that we can track this and then report that rsync fails? or what should be done?

@szaimen szaimen added the help wanted Extra attention is needed label Feb 11, 2025
@szaimen szaimen modified the milestones: v10.6.0, next, v10.6.1 Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtrichards joshtrichards Awaiting requested review from joshtrichards

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
2. developing Work in progress enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

Consider setting set -eu globally in nextcloud container entrypoint to catch more errors
1 participant
@szaimen