Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighted counter is broken on dark mode #3249

Closed
nickvergessen opened this issue Sep 14, 2022 · 2 comments · Fixed by nextcloud/server#34210
Closed

Highlighted counter is broken on dark mode #3249

nickvergessen opened this issue Sep 14, 2022 · 2 comments · Fixed by nextcloud/server#34210
Assignees
@skjnldsv
Labels
2. developing Work in progress accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: list-item-icon Related to the list-item-icon component

Comments

@nickvergessen
Copy link
Contributor

Items are:

  • Outlined
  • Highlighted
  • Normal
Bright Dark
Bildschirmfoto vom 2022-09-14 09-48-33 Bildschirmfoto vom 2022-09-14 09-48-23

The difference between backgrounds of highlighted and normal is non-existant and especially the missing contrast of the font on normal is an issue
@nickvergessen nickvergessen added bug Something isn't working 1. to develop Accepted and waiting to be taken care of accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: list-item-icon Related to the list-item-icon component labels Sep 14, 2022
@nickvergessen nickvergessen mentioned this issue Sep 14, 2022
Merged
@ChristophWurst ChristophWurst mentioned this issue Sep 14, 2022
Merged
@nickvergessen
Copy link
Contributor Author

Related server PR that removed at least the -lighter var which is used.
nextcloud/server#33946

But even when restoring the var the look is not good

@nickvergessen
Copy link
Contributor Author

Seems to be a problem with the math of the variables in server.
@skjnldsv is working on a patch

@nickvergessen nickvergessen added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Sep 23, 2022
@skjnldsv skjnldsv mentioned this issue Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skjnldsv skjnldsv

Labels
2. developing Work in progress accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: list-item-icon Related to the list-item-icon component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing missing theming variables nextcloud/server
2 participants
@nickvergessen @skjnldsv