Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the unregister function to the public API #574

Closed
susnux opened this issue Jan 26, 2023 · 1 comment · Fixed by #579
Closed

Add the unregister function to the public API #574

susnux opened this issue Jan 26, 2023 · 1 comment · Fixed by #579
Labels
enhancement New feature or request question Further information is requested

Comments

@susnux
Copy link
Contributor

susnux commented Jan 26, 2023

Currently we provide _unregister as it was and is provided by Nextcloud core in OC.L10N.
The docstring and the dash prefix indicates this function is part of private API, but it would be useful to have this function on the public API.
@susnux susnux added enhancement New feature or request question Further information is requested labels Jan 26, 2023
@ShGKme
Copy link
Contributor

ShGKme commented Feb 2, 2023

Sounds reasonable to me.

@susnux susnux mentioned this issue Feb 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Promote unregister function to public API nextcloud-libraries/nextcloud-l10n
2 participants
@susnux @ShGKme