Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nextcloud-libraries/eslint-config
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.6
Choose a base ref
...
head repository: nextcloud-libraries/eslint-config
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.1.0
Choose a head ref
  • 6 commits
  • 3 files changed
  • 4 contributors

Commits on Oct 16, 2019

  1. Bump webpack from 4.41.0 to 4.41.2

    Bumps [webpack](https://github.com/webpack/webpack) from 4.41.0 to 4.41.2.
    - [Release notes](https://github.com/webpack/webpack/releases)
    - [Commits](webpack/webpack@v4.41.0...v4.41.2)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored Oct 16, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    e0e1da2 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    2b2f65f View commit details

Commits on Oct 25, 2019

  1. consolidate config

    korelstar authored Oct 25, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    7b66fe8 View commit details

Commits on Oct 26, 2019

  1. add comma-dangle rule

    korelstar committed Oct 26, 2019
    Copy the full SHA
    b076cb3 View commit details
  2. consolidate config (#8)

    consolidate config
    skjnldsv authored Oct 26, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    08879e6 View commit details
  3. 0.1.0

    skjnldsv committed Oct 26, 2019

    Verified

    This commit was signed with the committer’s verified signature.
    skjnldsv John Molakvoæ
    Copy the full SHA
    95b7506 View commit details
Showing with 59 additions and 46 deletions.
  1. +23 −22 index.js
  2. +35 −23 package-lock.json
  3. +1 −1 package.json
45 changes: 23 additions & 22 deletions index.js
Original file line number Diff line number Diff line change
@@ -8,39 +8,34 @@ module.exports = {
},
parserOptions: {
parser: 'babel-eslint',
ecmaVersion: 6
ecmaVersion: 6,
},
extends: [
'eslint:recommended',
'plugin:import/errors',
'plugin:import/warnings',
'plugin:node/recommended',
'plugin:vue/essential',
'plugin:vue/recommended',
'plugin:nextcloud/recommended',
'standard'
'standard',
],
settings: {
'import/resolver': {
node: {
paths: ['src'],
extensions: ['.js', '.vue']
}
}
extensions: ['.js', '.vue'],
},
},
},
plugins: ['vue', 'node'],
rules: {
// space before function ()
'space-before-function-paren': ['error', 'never'],
// curly braces always space
'object-curly-spacing': ['error', 'always'],
// stay consistent with array brackets
'array-bracket-newline': ['error', 'consistent'],
// 1tbs brace style
'brace-style': 'error',
// tabs only
// tabs only for indentation
indent: ['error', 'tab'],
'no-tabs': ['off'],
'no-tabs': ['error', { allowIndentationTabs: true }],
'vue/html-indent': ['error', 'tab'],
// only debug console
'no-console': ['error', { allow: ['error', 'warn', 'info', 'debug'] }],
@@ -51,13 +46,17 @@ module.exports = {
// ternary on multiline
'multiline-ternary': ['error', 'always-multiline'],
// force proper JSDocs
'valid-jsdoc': [2, {
'valid-jsdoc': ['error', {
prefer: {
return: 'returns'
return: 'returns',
},
requireReturn: false,
requireReturnDescription: false
requireReturnDescription: false,
}],
// disallow use of "var"
'no-var': 'error',
// suggest using const
'prefer-const': 'error',
// es6 import/export and require
'node/no-unpublished-require': ['off'],
'node/no-unsupported-features/es-syntax': ['off'],
@@ -67,23 +66,25 @@ module.exports = {
// force name
'vue/match-component-file-name': ['error', {
extensions: ['jsx', 'vue', 'js'],
shouldMatchCase: true
shouldMatchCase: true,
}],
// space before self-closing elements
'vue/html-closing-bracket-spacing': 'error',
// no ending html tag on a new line
'vue/html-closing-bracket-newline': ['error', { multiline: 'never' }],
// check vue files too
'node/no-missing-import': ['error', {
tryExtensions: ['.js', '.vue']
tryExtensions: ['.js', '.vue'],
}],
// code spacing with attributes
'vue/max-attributes-per-line': ['error', {
singleline: 3,
multiline: {
max: 1,
allowFirstLine: true
}
}]
}
};
allowFirstLine: true,
},
}],
// always add a trailing comma (for diff readability)
'comma-dangle': ['warn', 'always-multiline'],
},
}
58 changes: 35 additions & 23 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "eslint-config-nextcloud",
"version": "0.0.6",
"version": "0.1.0",
"description": "Eslint shared config for nextcloud vue.js apps",
"main": "index.js",
"repository": {