Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Outside click not hiding search results #11893

Open
kavania2002 opened this issue Sep 23, 2024 · 1 comment · May be fixed by #11925
Open

Issue: Outside click not hiding search results #11893

kavania2002 opened this issue Sep 23, 2024 · 1 comment · May be fixed by #11925
Labels
documentation Relates to documentation good first issue Good issue to take for first time contributors triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime.

Comments

@kavania2002
Copy link
Contributor

kavania2002 commented Sep 23, 2024

What is the improvement or update you wish to see?

The search component does not hide results when the user clicks outside of the results box. I would like to see the search results automatically hidden when an outside click is detected.

Is there any context that might help us understand?

Currently, when using the search functionality in the component, the results remain visible even if the user clicks outside the search results area. This creates a poor user experience as the results should disappear once the user clicks outside. Adding an event listener to detect outside clicks and hide the results will improve usability.

Does the docs page already exist? Please link to it.

https://authjs.dev/getting-started

Please assign this issue to me. I would be happy to give it a try.

@kavania2002 kavania2002 added documentation Relates to documentation triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime. labels Sep 23, 2024
@balazsorban44 balazsorban44 added the good first issue Good issue to take for first time contributors label Sep 25, 2024
Copy link

This issue was marked with the good first issue label by a maintainer.

This means that it is a good candidate for someone interested in contributing to the project, but does not know where to start.

Have a look at the Contributing Guide first.

This will help you set up your development environment to get started. When you are ready, open a PR, and link back to this issue in the form of adding Fixes #1234 to the PR description, where 1234 is the issue number. This will auto-close the issue when the PR gets merged, making it easier for us to keep track of what has been fixed.

Please make sure that - if applicable - you add tests for the changes you make.

If you have any questions, feel free to ask in the comments below or the PR. Generally, you don't need to @mention anyone directly, as we will get notified anyway and will respond as soon as we can)

Note

There is no need to ask for permission "can I work on this?" Please, go ahead if there is no linked PR 🙂

@blan19 blan19 linked a pull request Sep 30, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to documentation good first issue Good issue to take for first time contributors triage Unseen or unconfirmed by a maintainer yet. Provide extra information in the meantime.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants