-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FaunaDB should be a dev dependency, not a regular one #1012
Comments
We have something called |
Yeah, I see your point, it should be implemented as outlined here, then: https://github.com/yarnpkg/rfcs/blob/master/accepted/0000-optional-peer-dependencies.md#2-detailed-design |
I think we use this at the moment: https://github.com/christkv/require_optional |
Unfortunately, that doesn’t seem to be a living standard. However, the |
cc @iaincollins |
https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta Looks like it is in npm@7 now! |
Fauna has been removed for now, see the explanation at #1146 |
As I’ve noticed in the latest canary release (
3.2.0-canary.3
),faunadb
has been added as a dependency, but it doesn’t seem to be used besides a test. I would like to suggest addingfaunadb
todevDependencies
while removing it fromdependencies
.The text was updated successfully, but these errors were encountered: