Skip to content

Commit

Permalink
style : 클래스 상수 개행 삭제 및 상수와 인스턴스 변수간 개행 추가
Browse files Browse the repository at this point in the history
  • Loading branch information
xlffm3 committed Jun 7, 2020
1 parent 4de92a9 commit 2f232ec
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 14 deletions.
2 changes: 1 addition & 1 deletion src/main/java/ladder/domain/LadderFactory.java
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package ladder.domain;

public class LadderFactory {

private static final int MINIMUM_LADDER_HEIGHT = 1;

private final int ladderHeight;

public LadderFactory(int ladderHeight) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/ladder/domain/Line.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
import java.util.stream.Collectors;

public class Line {

private static final int MINIMUM_PLAYER_COUNTS = 1;

private final List<Point> points;

private Line(List<Point> points) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/ladder/domain/Player.java
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package ladder.domain;

public class Player {

private static final int MAXIMUM_NAME_LENGTH = 5;

private final String name;

public Player(String name) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/ladder/domain/Point.java
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package ladder.domain;

public class Point {

private static final int RANDOM_NUMBER_BOUNDARY = 5;

private final boolean isExisting;

public Point(boolean isExisting) {
Expand Down
5 changes: 2 additions & 3 deletions src/main/java/ladder/domain/RandomDrawingLineStrategy.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,11 @@
import java.util.Random;

public class RandomDrawingLineStrategy implements DrawingLineStrategy {

private static final int LOOP_ZERO = 0;
private static final int LINE_WIDTH_CONSTANT = 1;
private static final int INDEX_CONSTANT = 1;
private static final int RANDOM_NUMBER_RANGE = 10;
private static final Random random = new Random();
private static final Random RANDOM = new Random();

@Override
public List<Point> drawLine(int playerCounts) {
Expand Down Expand Up @@ -41,6 +40,6 @@ private boolean isLastPointExisting(List<Point> points) {
}

private int generateRandomNumber() {
return random.nextInt(RANDOM_NUMBER_RANGE);
return RANDOM.nextInt(RANDOM_NUMBER_RANGE);
}
}
7 changes: 3 additions & 4 deletions src/main/java/ladder/view/InputView.java
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,19 @@
import java.util.Scanner;

public class InputView {

private static Scanner scanner = new Scanner(System.in);
private static final Scanner SCANNER = new Scanner(System.in);

private InputView() {
}

public static List<String> inputPlayerNames() {
System.out.println(ViewMessages.INSTRUCTION_PLAYER_NAMES);
String[] inputPlayerNames = scanner.nextLine().split(ViewMessages.COMMA);
String[] inputPlayerNames = SCANNER.nextLine().split(ViewMessages.COMMA);
return Arrays.asList(inputPlayerNames);
}

public static int inputLadderHeight() {
System.out.println(ViewMessages.INSTRUCTION_LADDER_HEIGHT);
return Integer.parseInt(scanner.nextLine());
return Integer.parseInt(SCANNER.nextLine());
}
}
1 change: 0 additions & 1 deletion src/main/java/ladder/view/OutputView.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import java.util.List;

public class OutputView {

private static final int LOOP_ZERO = 0;
private static final int BLANK_BOUNDARY = 0;
private static final int NAME_CHUNK_LENGTH = 5;
Expand Down
2 changes: 0 additions & 2 deletions src/main/java/ladder/view/ViewMessages.java
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
package ladder.view;

public class ViewMessages {

public static final String INSTRUCTION_PLAYER_NAMES = "참여할 사람 이름을 입력하세요. (이름은 쉼표(,)로 구분하세요.)";
public static final String INSTRUCTION_LADDER_HEIGHT = "최대 사다리 높이는 몇 개인가요?";

public static final String COMMA = ",";
public static final String BLANK = " ";
public static final String LINE_PREFIX = " ";
Expand Down

0 comments on commit 2f232ec

Please sign in to comment.