-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to correctly remove ESI options set in turpentine_esi.xml #951
Comments
I'm actually working up a way to do this via config in local.xml, will hopefully merge it into devel today or tomorrow. |
I've just merged #970 which allows you to override the settings in turpentine_esi.xml via your local.xml config:
Unless problems pop up, this will be in the next update of master! |
This is a great solution. Is it included in Wiki? |
Thanks - I will update the docs once it's live in the master branch. |
Thanks @aricwatson, nice work |
This has been added to the wiki. |
I'm wondering what is the best practice to remove the ESI options set in
turpentine_esi.xml
?To give some context I found that after I installed the turpentine module & got it working with Varnish, my dynamic cart my header was not working, it was displaying the default Magento topcart and not the one from our theme.
While debugging the issue I found if I removed the below code block from
turpentine_esi.xml
my dynamic cart started working properly, correctly holding the number for cart items for each user.I believe that as the our theme's topcart is defined in the
header
this is why it continued to work after removing the above code, infact when I removed the header esi options set inturpentine_esi.xml
I could see that my dynamic cart broke, not holding the correct number of items for each user.So my question is how do I remove the
cart_sidebar
block fromturpentine_esi.xml
without deleting it from that file? Can I put something in my own layoutlocal.xml
which would remove it so I can maintain upgrade-ability?The text was updated successfully, but these errors were encountered: