Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replaced instances of substr() with substring() #2274

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

bizob2828
Copy link
Member

Description

Most of the updates were clean. Only one that was referencing a negative index needed adjusted to work with substring.

How to Test

Please describe how you have tested these changes. Have you run the code against an example application?
What steps did you take to ensure that the changes are working correctly?

Related Issues

Closes NR-82088

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.32%. Comparing base (6c964b2) to head (06187b2).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2274      +/-   ##
==========================================
- Coverage   96.32%   96.32%   -0.01%     
==========================================
  Files         284      284              
  Lines       45178    45181       +3     
==========================================
+ Hits        43518    43520       +2     
- Misses       1660     1661       +1     
Flag Coverage Δ
integration-tests-16.x 50.10% <14.28%> (-0.01%) ⬇️
integration-tests-18.x 49.23% <14.28%> (-0.01%) ⬇️
integration-tests-20.x 49.24% <14.28%> (-0.01%) ⬇️
unit-tests-16.x 89.17% <100.00%> (+<0.01%) ⬆️
unit-tests-18.x 89.16% <100.00%> (+<0.01%) ⬆️
unit-tests-20.x 89.16% <100.00%> (+<0.01%) ⬆️
versioned-tests-16.x 77.57% <50.00%> (-0.06%) ⬇️
versioned-tests-18.x 78.56% <50.00%> (-0.09%) ⬇️
versioned-tests-20.x 78.56% <50.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants