Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for redis v4 legacyMode client.v4.<command> #2200

Merged
merged 1 commit into from
May 20, 2024

Conversation

bizob2828
Copy link
Member

Description

We had a customer using some legacyMode of redis v4. When you do that you access commands via client.v4.<cmd>. We weren't instrumenting that object. This PR fixes that.

How to Test

npm run versioned:internal redis

Related Issues

Closes #2199

Copy link
Contributor

@jsumners-nr jsumners-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bizob2828 bizob2828 merged commit b2284c5 into newrelic:main May 20, 2024
27 of 28 checks passed
@bizob2828 bizob2828 deleted the redis-v4-shim branch May 20, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add support for redisClient.v4 commands
2 participants