From 16cd80b93f7d074891b006e4b23518490d381814 Mon Sep 17 00:00:00 2001 From: Ahmed Ejaz Date: Tue, 10 Oct 2023 20:57:06 +0500 Subject: [PATCH] #2247, removes unused variable warnings in tests suite --- test/new_relic/agent/configuration/manager_test.rb | 4 ++-- .../agent/monitors/synthetics_monitor_test.rb | 1 - test/new_relic/agent/tracer_test.rb | 2 +- test/new_relic/dependency_detection_test.rb | 12 +++--------- 4 files changed, 6 insertions(+), 13 deletions(-) diff --git a/test/new_relic/agent/configuration/manager_test.rb b/test/new_relic/agent/configuration/manager_test.rb index 4d1f2a0cef..65c4010486 100644 --- a/test/new_relic/agent/configuration/manager_test.rb +++ b/test/new_relic/agent/configuration/manager_test.rb @@ -494,7 +494,7 @@ def test_apply_transformations_reraises_errors def test_auto_determined_values_stay_cached name = :knockbreck_manse - dd = DependencyDetection.defer do + DependencyDetection.defer do named(name) executes { use_prepend? } end @@ -512,7 +512,7 @@ def test_auto_determined_values_stay_cached def test_unsatisfied_values_stay_cached name = :tears_of_the_kingdom - dd = DependencyDetection.defer do + DependencyDetection.defer do named(name) # guarantee the instrumentation's dependencies are unsatisfied diff --git a/test/new_relic/agent/monitors/synthetics_monitor_test.rb b/test/new_relic/agent/monitors/synthetics_monitor_test.rb index 3fb0475fb8..31119d91b1 100644 --- a/test/new_relic/agent/monitors/synthetics_monitor_test.rb +++ b/test/new_relic/agent/monitors/synthetics_monitor_test.rb @@ -79,7 +79,6 @@ def test_records_synthetics_state_from_header end def test_records_synthetics_info_header_if_available - key = SyntheticsMonitor::SYNTHETICS_HEADER_KEY synthetics_payload = [VERSION_ID] + STANDARD_DATA info_payload = <<~PAYLOAD { diff --git a/test/new_relic/agent/tracer_test.rb b/test/new_relic/agent/tracer_test.rb index 52db1c7360..5b7eabd91b 100644 --- a/test/new_relic/agent/tracer_test.rb +++ b/test/new_relic/agent/tracer_test.rb @@ -308,7 +308,7 @@ def test_traced_threads_dont_keep_using_finished_transaction txn = Tracer.start_transaction(name: 'Controller/blogs/index', category: :controller) threads = [] threads << Thread.new do - segment = Tracer.start_segment(name: 'Custom/MyClass/myoperation') + Tracer.start_segment(name: 'Custom/MyClass/myoperation') sleep(0.01) until txn.finished? threads << Thread.new do diff --git a/test/new_relic/dependency_detection_test.rb b/test/new_relic/dependency_detection_test.rb index b3c627c649..b4223340a5 100644 --- a/test/new_relic/dependency_detection_test.rb +++ b/test/new_relic/dependency_detection_test.rb @@ -211,11 +211,9 @@ def test_config_enabling_with_enabled end def test_config_enabling_with_auto - executed = false - dd = DependencyDetection.defer do named(:testing) - executes { executed = true } + executes { true } end with_config(:'instrumentation.testing' => 'auto') do @@ -228,11 +226,9 @@ def test_config_enabling_with_auto end def test_config_enabling_with_prepend - executed = false - dd = DependencyDetection.defer do named(:testing) - executes { executed = true } + executes { true } end with_config(:'instrumentation.testing' => 'prepend') do @@ -245,11 +241,9 @@ def test_config_enabling_with_prepend end def test_config_enabling_with_chain - executed = false - dd = DependencyDetection.defer do named(:testing) - executes { executed = true } + executes { true } end with_config(:'instrumentation.testing' => 'chain') do