Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padrino Multiverse tests do not accurately test instrumentation installation #802

Closed
tannalynn opened this issue Oct 1, 2021 · 2 comments

Comments

@tannalynn
Copy link
Contributor

A bug was reported (#737) that the padrino instrumentation was not working correctly. After looking into it we found that the padrino instrumentation was not being installed in such a way that it would work. The instrumentation was being installed too late for us to prepend, as the ancestor chain had already been established on the objects using the modules we prepended our instrumentation to.
While we were able to correct the issues with instrumentation installation, we were not able to figure out a way to update our padrino tests to load the same way as running a padrino app outside of multiverse does. The tests do still test the functionality of the instrumentation, however it is not able to accurately test IF the instrumentation actually gets installed.
We should update our multiverse tests to load padrino in the same way an application using padrino does.

@kaylareopelle
Copy link
Contributor

A similar issue was raised during the resolution of an issue related to Rails load order and initializers.

Issue: #662
PR: #806

@angelatan2
Copy link
Contributor

The original failure no longer occurs. Improvements have been made to our test and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants