Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidekiq: Evaluate the use of ActiveJob as a Sidekiq interactor - look for any gaps in instrumentation #2835

Open
fallwith opened this issue Aug 30, 2024 · 1 comment

Comments

@fallwith
Copy link
Contributor

With #2195, we investigated instrumentation coverage for Sidekiq jobs' various perform* methods. A comment on that issue suggested the inclusion of perform_now as well. But perform_now and perform_later are ActiveJob-isms and were considered out of scope for #2195 and worthy of their own separate issue.

ActiveJob provides a standard way of interacting with job runners, Sidekiq included. We currently have test suites that utilize Sidekiq without Rails (without ActiveSupport even) and Rails without Sidekiq. We really ought to create a suite that blends the two and specifically uses perform_now and perform_later to kick off Sidekiq jobs. What instrumentation is produced in these scenarios? Is there ActiveSupport notifications driven instrumentation from the use of ActiveJob? Is the Sidekiq server middleware driven Sidekiq job instrumentation being engaged? Anything duplication overlap or any gaps in instrumentation coverage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant