nri-mssql-experimental #785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback! |
jpvajda
suggested changes
Feb 4, 2022
| name: nri-mssql-experimental | ||
| title: Microsoft SQL Server with Query Plan logging | ||
| description: | | ||
| The original SQL Server nri with added Query Plan logging |
There was a problem hiding this comment.
Would you be able to add more content to the description? This is a little light on product value and why it's useful to an end user.
| The original SQL Server nri with added Query Plan logging | ||
|
|
||
| summary: | | ||
| Send SQL Server Query Plans to the New Relic Logging API |
There was a problem hiding this comment.
Same comment as above, this summary could use a little more detail.
| - name: Apigee Distributed Tracing documentation | ||
| description: | | ||
| Installation and configuration instructions | ||
| url: https://github.com/newrelic-experimental/nri-mssql-experimental |
There was a problem hiding this comment.
Is there a reference to a docs.newelic.com page you can use here, along with a link to the repository?
There was a problem hiding this comment.
@jpvajda We haven't been adding our newrelic-experimental projects to doc.newrelic.com as they're unsupported and not "Product"
jpvajda
added
duplicate
github-actions bot
pushed a commit
that referenced
this pull request
Feb 8, 2022
# [0.97.0](v0.96.0...v0.97.0) (2022-02-08) ### Bug Fixes * changed name of cli quickstart ([12a34be](12a34be)) * remove unchecked concurrency ([135a2a5](135a2a5)) * removed line in json ([9ba700b](9ba700b)) * Update target type for new install plans ([bfefd28](bfefd28)) ### Features * add install plans for cloud quickstarts ([f96c31f](f96c31f)) * add nerdletState to validation query ([c20081b](c20081b)) * add retries to nerdgraph calls ([2ce0bc4](2ce0bc4)) * added CLI quickstart ([3555333](3555333)) * added pulumi quickstart ([d0a9e1d](d0a9e1d)) * added terraform quickstart ([41eb8c8](41eb8c8)) * **contentsquare:** Added a quickstart for Contentsquare ([001629a](001629a)) * generate docs from graphql schema ([0e9ab55](0e9ab55)) * generate schema docs from GraphQL ([039b9c5](039b9c5)) * **mssql-queryplan:** Adding dashboard to [#785](#785) ([a2985fe](a2985fe)) * **oac:** improved descriptions and summary ([dff1b54](dff1b54)) * **pack:** Updated ec2 quickstart ([4397f94](4397f94)) * restructure primary/fallback install plan step input ([711ca3b](711ca3b)) * retry graphql request for specific status codes ([5010595](5010595))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An experimental version of the original New Relic nri-mssql with added query plan logging to the Log API. nri-mssql would not accept the change as a PR due to the use of the Log API so this will live in newrelic-experimental on its own.
Pre merge checklist
Screenshots
Not applicable