-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint: Update install plans where OS should be windows only or the se… #608
Conversation
…tup nerdlet should be used
Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 more small changes and I think this is good to go then
Co-authored-by: Justin Eveland <jeveland@newrelic.com>
Co-authored-by: Justin Eveland <jeveland@newrelic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
## [0.72.1](v0.72.0...v0.72.1) (2021-12-03) ### Bug Fixes * Merge pull request [#608](#608) from newrelic/maint/update-install-plans ([0bf3e72](0bf3e72))
🎉 This PR is included in version 0.72.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
…tup nerdlet should be used
Summary
-Removing the targetedInstall nerdlet for node and using the setup nerdlet
-Removing targetedInstall nerdlet for php quickstarts that do NOT require php-fpm
-Created a separate php install plan for php-fpm quickstarts
-Removing linux as a valid OS for dotnet quickstarts that only support windows
-Created a separate dotnet install plan for windows-only quickstarts