maint: Update install plans where OS should be windows only or the se… #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tup nerdlet should be used
|
Thank you for your contribution, our team will be reviewing this shortly, please be available for any follow up questions or code review feedback! |
github-actions
bot
added
triage-needed
jbeveland27
reviewed
Dec 3, 2021
jbeveland27
reviewed
Dec 3, 2021
jbeveland27
reviewed
Dec 3, 2021
jbeveland27
reviewed
Dec 3, 2021
jbeveland27
reviewed
Dec 3, 2021
jbeveland27
reviewed
Dec 3, 2021
jbeveland27
suggested changes
Dec 3, 2021
Co-authored-by: Justin Eveland <jeveland@newrelic.com>
Co-authored-by: Justin Eveland <jeveland@newrelic.com>
github-actions bot
pushed a commit
that referenced
this pull request
Dec 3, 2021
## [0.72.1](v0.72.0...v0.72.1) (2021-12-03) ### Bug Fixes * Merge pull request [#608](#608) from newrelic/maint/update-install-plans ([0bf3e72](0bf3e72))
|
🎉 This PR is included in version 0.72.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tup nerdlet should be used
Summary
-Removing the targetedInstall nerdlet for node and using the setup nerdlet
-Removing targetedInstall nerdlet for php quickstarts that do NOT require php-fpm
-Created a separate php install plan for php-fpm quickstarts
-Removing linux as a valid OS for dotnet quickstarts that only support windows
-Created a separate dotnet install plan for windows-only quickstarts