Removal of CompletableFuture/Completion.tryFire method instrumentation causes loss of token linking

[kford-newrelic]

Description

A customer was upgrading from the 7.4.3 agent to the 7.11.1 version. While doing this upgrade, they noticed that their transaction time - which used to be measured in milliseconds - was now returning microsecond response times. Transaction traces with the new agent also appears to have fewer segments being created.

Example

The current thinking is that the removal of instrumentation support for the CompletableFuture/Completion.tryFire() method may be the root of the problem, since the transaction is essentially being lost. Example code fragment:

// code placeholder
@Trace(dispatcher = true)
private PipelineExecutionContext createDefaultExecutionContext(InboundExecutionContext inboundExecutionContext, DefaultMessage message) {
...
NewRelicIteratingPipelineExecutionContext pipelineExecutionContext = pipeline.createPipelineExecutionContext(
When constructing the NewRelicIteratingPipelineExecutionContext we grab the NR token like this:
public class NewRelicIteratingPipelineExecutionContext extends IteratingPipelineExecutionContext {
private final Token newRelicToken = NewRelic.getAgent().getTransaction().getToken();
At the end of the traction we do this:
@Override
public void complete() {
try {
super.complete();
}
finally {
newRelicToken.linkAndExpire();
}
} 

[workato-integration]

https://new-relic.atlassian.net/browse/NR-135277

[kford-newrelic]

Reviewing...

[kford-newrelic]

Original customer went dark but #1140 may have addressed this issue. Need to retest and confirm/deny.

[kford-newrelic]

Closing this issue as resolved. Will attempt to reach the customer reporting the issue to confirm. Will re-open if necessary.