Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove errorCollector.ignoreErrors config #668

Closed
vuqtran88 opened this issue Aug 1, 2021 · 0 comments
Closed

Remove errorCollector.ignoreErrors config #668

vuqtran88 opened this issue Aug 1, 2021 · 0 comments
Assignees

Comments

@vuqtran88
Copy link
Contributor

vuqtran88 commented Aug 1, 2021

Consider the following:

  • Removes the errorCollector.ignoreErrors config code usages in the agent.
  • Updates the default shipped newrelic.config with the replaced config.
    changing from:
	<errorCollector enabled="true">
		<ignoreErrors>
			<exception>System.IO.FileNotFoundException</exception>
			<exception>System.Threading.ThreadAbortException</exception>
		</ignoreErrors>

to

	<errorCollector enabled="true">
		< ignoreClasses >
			< errorClass >System.IO.FileNotFoundException</errorClass >
			< errorClass >System.Threading.ThreadAbortException</errorClass >
		</ignoreClasses >
  • Logs out "This {oldConfiguration} is obsoleted. Please use this {newConfiguration}." message when these configs are used in the agent v9.0. This will help Support with troubleshooting.
  • Updates related integration tests.

Notes:
We don't want to remove these deprecated configs from the xml schema because it will cause configuration parsing exception when upgrade which will crash the agent.

Acceptance Criterion:

  • Integration tests pass.
  • Make sure SSC for ignored/expected error still works. SSC should override local config.
  • Expect warning log messages when old configs are used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants