Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grpc channel shutdown can cause license_key is required error message. #627

Closed
vuqtran88 opened this issue Jul 1, 2021 · 0 comments · Fixed by #663
Closed

Grpc channel shutdown can cause license_key is required error message. #627

vuqtran88 opened this issue Jul 1, 2021 · 0 comments · Fixed by #663
Labels
bug Something isn't working

Comments

@vuqtran88
Copy link
Contributor

Description
When something causes the grpc channel disconnect, the agent tries to shutdown and reconnect. It also resets the metadata object which has the license key header in it. This line of code causes the issue:

.

Even though when the agent reconnects, the MetadataHeaders will get set again. The problem is, during the connection shutdown, the agent had a bunch of streaming workers that were still streaming data with the cleared MetadataHeaders.

A potential fix is here https://github.com/newrelic/newrelic-dotnet-agent/tree/fix-license-key-header-issue.

Expected Behavior
Streaming worker should not use null value MetadataHeaders to send spans when the channel connection is restarting.

@vuqtran88 vuqtran88 added the bug Something isn't working label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant