fix: Incorrect string comparison in the profiler caused constructor instrumentation to fail on Linux #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nr-ahemsath
previously approved these changes
Dec 4, 2024
chore: Update Profiler NuGet Package Reference to v10.34.0.10. Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
nrcventura
previously approved these changes
Dec 4, 2024
chore: Update Profiler NuGet Package Reference to v10.34.0.14. Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2912 +/- ##
==========================================
- Coverage 81.42% 81.41% -0.01%
==========================================
Files 465 465
Lines 29563 29563
Branches 3278 3278
==========================================
- Hits 24071 24069 -2
- Misses 4698 4699 +1
- Partials 794 795 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tippmar-nr
changed the title
tippmar-nr
changed the title
nr-ahemsath
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.
Description
The profiler is supposed to allow instrumentation of constructors, but we found that the string comparison operator being used didn't work correctly under Linux. This PR changes the comparison to use a cross-platform version of
wcscmp()instead.Fixes #2918
Author Checklist
Reviewer Checklist