Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add config option for providing AWS account ID for linking #2851

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

chynesNR
Copy link
Member

Adds the ability to provide an AWS Account ID, which can be used to help link related entities.

This functionality is needed for multiple feature branches which is why I'm merging to main first, even though this won't be used yet.

@chynesNR chynesNR requested a review from a team as a code owner October 24, 2024 18:08
Copy link
Member

@nrcventura nrcventura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think we just need a few more test updates to increase the patch coverage.

I'm also assuming that the updates to the instrumentation that will use this setting will be handled in separate PRs.

tippmar-nr
tippmar-nr previously approved these changes Oct 24, 2024
@chynesNR
Copy link
Member Author

Looks good to me. I think we just need a few more test updates to increase the patch coverage.

I'm also assuming that the updates to the instrumentation that will use this setting will be handled in separate PRs.

Correct, there are separate tasks for that work and testing

nrcventura
nrcventura previously approved these changes Oct 24, 2024
tippmar-nr
tippmar-nr previously approved these changes Oct 25, 2024
@chynesNR chynesNR dismissed stale reviews from tippmar-nr and nrcventura via c6a81d6 October 25, 2024 17:01
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.42%. Comparing base (f24a5da) to head (c6a81d6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2851      +/-   ##
==========================================
- Coverage   81.42%   81.42%   -0.01%     
==========================================
  Files         464      464              
  Lines       29496    29504       +8     
  Branches     3261     3262       +1     
==========================================
+ Hits        24017    24023       +6     
- Misses       4683     4684       +1     
- Partials      796      797       +1     
Flag Coverage Δ
Agent 82.32% <100.00%> (-0.01%) ⬇️
Profiler 73.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/Agent/Core/Configuration/DefaultConfiguration.cs 89.62% <100.00%> (+0.04%) ⬆️
.../Agent/Core/Configuration/ReportedConfiguration.cs 95.76% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@chynesNR chynesNR merged commit 936b6f6 into main Oct 25, 2024
102 checks passed
@chynesNR chynesNR deleted the feature/aws-account-id-config branch October 25, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants