-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add config option for providing AWS account ID for linking #2851
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think we just need a few more test updates to increase the patch coverage.
I'm also assuming that the updates to the instrumentation that will use this setting will be handled in separate PRs.
Correct, there are separate tasks for that work and testing |
tests/Agent/UnitTests/Core.UnitTest/Configuration/DefaultConfigurationTests.cs
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2851 +/- ##
==========================================
- Coverage 81.42% 81.42% -0.01%
==========================================
Files 464 464
Lines 29496 29504 +8
Branches 3261 3262 +1
==========================================
+ Hits 24017 24023 +6
- Misses 4683 4684 +1
- Partials 796 797 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Adds the ability to provide an AWS Account ID, which can be used to help link related entities.
This functionality is needed for multiple feature branches which is why I'm merging to
main
first, even though this won't be used yet.