Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Profiler to check whether Azure function mode support is enabled #2822

Merged
merged 9 commits into from
Oct 10, 2024

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Oct 9, 2024

Updates the Profiler to inspect the NEW_RELIC_AZURE_FUNCTION_MODE_ENABLED environment variable.

If the variable doesn't exist, we don't exclude any Azure function processes from instrumentation, which matches behavior prior to implementing Azure function support.

If the variable does exist, Azure function mode is only enabled if the variable has a value of 1 or true.

@tippmar-nr tippmar-nr requested a review from a team as a code owner October 9, 2024 16:48
github-actions bot and others added 4 commits October 9, 2024 12:16
chore: Update Profiler NuGet Package Reference to v10.31.0.10.

Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
chore: Update Profiler NuGet Package Reference to v10.31.0.13.

Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
nrcventura
nrcventura previously approved these changes Oct 9, 2024
chynesNR
chynesNR previously approved these changes Oct 9, 2024
@tippmar-nr tippmar-nr dismissed stale reviews from chynesNR and nrcventura via e0b2e0f October 10, 2024 15:26
github-actions bot and others added 3 commits October 10, 2024 10:36
chore: Update Profiler NuGet Package Reference to v10.31.0.15.

Co-authored-by: tippmar-nr <120425148+tippmar-nr@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.24%. Comparing base (7c241f8) to head (4093edf).

Files with missing lines Patch % Lines
...nt/NewRelic/Profiler/Configuration/Configuration.h 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2822      +/-   ##
==========================================
+ Coverage   81.21%   81.24%   +0.02%     
==========================================
  Files         460      460              
  Lines       29219    29225       +6     
  Branches     3223     3223              
==========================================
+ Hits        23731    23743      +12     
+ Misses       4701     4697       -4     
+ Partials      787      785       -2     
Flag Coverage Δ
Agent 82.26% <ø> (+0.02%) ⬆️
Profiler 72.17% <90.90%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nt/NewRelic/Profiler/Configuration/Configuration.h 77.25% <90.90%> (+0.43%) ⬆️

... and 1 file with indirect coverage changes

@tippmar-nr tippmar-nr enabled auto-merge (squash) October 10, 2024 17:14
@tippmar-nr tippmar-nr merged commit 9669641 into main Oct 10, 2024
94 checks passed
@tippmar-nr tippmar-nr deleted the fix/azure-function-profiler-update branch October 10, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants