Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for the EnyimMemcachedCore client. #2781

Merged
merged 9 commits into from
Sep 25, 2024
Merged

Conversation

jaffinito
Copy link
Member

@jaffinito jaffinito commented Sep 23, 2024

Description

  • Adds support for EnyimMemcachedCore versions 2.X and 3.X with nearly all methods except MultiGet methods, sync and async.
  • Adds ContainerIntegration tests: (I expect these will change when net9.0 releases)
    • net8.0 with EnyimMemcachedCore v2.1.9
    • net6.0 with EnyimMemcachedCore v3.2.2

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@jaffinito jaffinito requested a review from a team as a code owner September 23, 2024 21:26
nrcventura
nrcventura previously approved these changes Sep 24, 2024
Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.24%. Comparing base (f032a9c) to head (2e1afff).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2781   +/-   ##
=======================================
  Coverage   81.23%   81.24%           
=======================================
  Files         460      460           
  Lines       29230    29230           
  Branches     3223     3223           
=======================================
+ Hits        23746    23748    +2     
+ Misses       4697     4696    -1     
+ Partials      787      786    -1     
Flag Coverage Δ
Agent 82.27% <ø> (+<0.01%) ⬆️
Profiler 72.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@jaffinito jaffinito merged commit 52bdc11 into main Sep 25, 2024
103 checks passed
@jaffinito jaffinito deleted the feature/memcached branch September 25, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants